Skip to content

Fix main branch issues#9553

Merged
weizhouapache merged 1 commit into
apache:mainfrom
shapeblue:420-fix-main-issues
Aug 20, 2024
Merged

Fix main branch issues#9553
weizhouapache merged 1 commit into
apache:mainfrom
shapeblue:420-fix-main-issues

Conversation

@nvazquez

Copy link
Copy Markdown
Contributor

Description

This PR fixes issues on main branch after the merge commit: 5bf81cf

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92 vishesh92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm. waiting for tests to pass.

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan package

@DaanHoogland

Copy link
Copy Markdown
Contributor

I think we can merge if packaging passes

@harikrishna-patnala harikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@codecov

codecov Bot commented Aug 20, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.54%. Comparing base (f84e043) to head (4cba308).
Report is 2 commits behind head on main.

Files Patch % Lines
.../hypervisor/kvm/storage/LinstorStorageAdaptor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main    #9553       +/-   ##
============================================
+ Coverage     4.17%   15.54%   +11.37%     
- Complexity       0    12000    +12000     
============================================
  Files          377     5499     +5122     
  Lines        30866   481744   +450878     
  Branches      5463    60574    +55111     
============================================
+ Hits          1288    74896    +73608     
- Misses       29432   398561   +369129     
- Partials       146     8287     +8141     
Flag Coverage Δ
uitests 4.17% <ø> (ø)
unittests 16.32% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apache apache deleted a comment from nvazquez Aug 20, 2024
@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@weizhouapache weizhouapache merged commit 296a44e into apache:main Aug 20, 2024
@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10710

@DaanHoogland DaanHoogland deleted the 420-fix-main-issues branch August 20, 2024 14:22
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 22, 2024
@DaanHoogland DaanHoogland added this to the 4.20.0.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants