Skip to content

UI: Improve router listing page#9551

Merged
DaanHoogland merged 2 commits into
apache:mainfrom
shapeblue:improve-router-listing-view
Aug 20, 2024
Merged

UI: Improve router listing page#9551
DaanHoogland merged 2 commits into
apache:mainfrom
shapeblue:improve-router-listing-view

Conversation

@vishesh92

@vishesh92 vishesh92 commented Aug 20, 2024

Copy link
Copy Markdown
Member

Description

This PR fixes #8008

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before patch:

Details

image

After patch:

Details

image

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9551 (QA-JID-425)

@codecov

codecov Bot commented Aug 20, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.17%. Comparing base (2ba64f2) to head (9123992).
Report is 5 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (2ba64f2) and HEAD (9123992). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (2ba64f2) HEAD (9123992)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #9551       +/-   ##
============================================
- Coverage     15.54%   4.17%   -11.38%     
============================================
  Files          5499     377     -5122     
  Lines        481706   30866   -450840     
  Branches      58660    5463    -53197     
============================================
- Hits          74879    1288    -73591     
+ Misses       398541   29432   -369109     
+ Partials       8286     146     -8140     
Flag Coverage Δ
uitests 4.17% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishesh92 vishesh92 added this to the 4.20.0.0 milestone Aug 20, 2024
@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the latest UI looks good to me

@vishesh92 @DaanHoogland

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9551 (QA-JID-426)

@vishesh92 vishesh92 force-pushed the improve-router-listing-view branch from 27f5e65 to 9123992 Compare August 20, 2024 11:26
@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9551 (QA-JID-427)

@DaanHoogland

Copy link
Copy Markdown
Contributor

tested in qa

@DaanHoogland DaanHoogland merged commit 7fb8d77 into apache:main Aug 20, 2024
@DaanHoogland DaanHoogland deleted the improve-router-listing-view branch August 20, 2024 12:18

@kiranchavala kiranchavala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Before fix

beforepr2-9551

beforepr1-9551

After fix

pr2-9551

pr-9551

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show all the tier's name associated with the VPC Virtual router

5 participants