Skip to content

UI: Add filter to list encrypted volumes#9548

Merged
DaanHoogland merged 1 commit into
mainfrom
add-is-encrypted-vol-filter
Aug 20, 2024
Merged

UI: Add filter to list encrypted volumes#9548
DaanHoogland merged 1 commit into
mainfrom
add-is-encrypted-vol-filter

Conversation

@Pearl1594

Copy link
Copy Markdown
Contributor

Description

This PR fixes: #9130

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

Added toggle button for filtering only encrypted volumes:
image

When set to true, passes 'isencrypted' parameter to the listVolumes API call:
image

When set to false, returns all non-encrypted volumes:
image

How did you try to break this feature and the system with this change?

@Pearl1594

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Aug 19, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.54%. Comparing base (2ba64f2) to head (42380ea).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##               main    #9548     +/-   ##
===========================================
  Coverage     15.54%   15.54%             
- Complexity    11995    11998      +3     
===========================================
  Files          5499     5499             
  Lines        481706   481720     +14     
  Branches      58660    61791   +3131     
===========================================
+ Hits          74879    74884      +5     
- Misses       398541   398548      +7     
- Partials       8286     8288      +2     
Flag Coverage Δ
uitests 4.17% <ø> (-0.01%) ⬇️
unittests 16.32% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9548 (QA-JID-424)

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm and tested in qa, but I think it can do with more testing (with real encrypted volumes)

@FelipeM525 FelipeM525 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR using the simulator build and it looks good to me!

images

image

image

image

image

@FelipeM525

Copy link
Copy Markdown
Contributor

@DaanHoogland In order to address your comment, I've also tested this PR in a local environment by creating an encrypted volume and testing the new filter.

Images

image

image

image

@DaanHoogland DaanHoogland merged commit 1ef0833 into main Aug 20, 2024
@DaanHoogland DaanHoogland deleted the add-is-encrypted-vol-filter branch August 20, 2024 14:34
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 22, 2024
@DaanHoogland DaanHoogland added this to the 4.20.0.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ui for listVolumes by isEncrypted

4 participants