Added update, enable, disable events to the updateStoragePool API by harikrishna-patnala · Pull Request #9543 · apache/cloudstack

harikrishna-patnala · 2024-08-19T12:23:40Z

Description

This PR addresses the issue #8494

Fixes the issue of missing Enable, Disable action events when trying to do that using updateStoragePool. Also added new Action event UPDATE.PS to the actual update storage pool event.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

harikrishna-patnala · 2024-08-19T12:24:34Z

@blueorangutan package

blueorangutan · 2024-08-19T12:26:04Z

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-08-19T12:31:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.16%. Comparing base (2ba64f2) to head (fe0a3bd).
Report is 75 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (2ba64f2) and HEAD (fe0a3bd). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (2ba64f2) HEAD (fe0a3bd)

unittests 1 0

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #9543       +/-   ##
============================================
- Coverage     15.54%   4.16%   -11.38%     
============================================
  Files          5499     377     -5122     
  Lines        481706   30889   -450817     
  Branches      58660    5466    -53194     
============================================
- Hits          74879    1288    -73591     
+ Misses       398541   29455   -369086     
+ Partials       8286     146     -8140

Flag	Coverage Δ
uitests	`4.16% <ø> (-0.01%)`	⬇️
unittests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-08-19T13:37:41Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10695

JoaoJandre · 2024-08-20T17:17:45Z

+        if (name != null ||
+                (tags != null && !tags.isEmpty()) ||
+                capacityIops != null ||
+                capacityBytes != null ||
+                (details != null && !details.isEmpty()) ||
+                url != null ||
+                isTagARule != null) {


We could use ObjectUtils.anyNotNull() for all non collection variables and CollectionUtils.isNotEmpty() for details and tags.

updated the code. Thanks @JoaoJandre

harikrishna-patnala · 2024-08-21T05:26:57Z

@blueorangutan package

blueorangutan · 2024-08-21T05:28:03Z

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-08-21T06:38:31Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10721

kiranchavala

LGTM

DISABLE, ENABLE, UPDATE PS events are properly generated

kiranchavala · 2024-08-21T08:19:30Z

@blueorangutan test

blueorangutan · 2024-08-21T08:20:05Z

@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

JoaoJandre

CLGTM, did not test it

blueorangutan · 2024-08-22T00:57:13Z

[SF] Trillian test result (tid-11123)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57312 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9543-t11123-kvm-ol8.zip
Smoke tests completed. 135 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_DeployVmAffinityGroup	`Error`	1.42	test_affinity_groups.py
test_01_non_strict_host_anti_affinity	`Error`	3.71	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	3.61	test_nonstrict_affinity_group.py
test_01_secure_vm_migration	`Error`	402.58	test_vm_life_cycle.py
test_13_migrate_volume_and_change_offering	`Error`	121.12	test_volumes.py

harikrishna-patnala · 2024-08-23T05:11:13Z

test_13_migrate_volume_and_change_offering failure is because of this PR change, will update the PR accordingly.

cc @DaanHoogland

harikrishna-patnala · 2024-08-23T05:47:19Z

@blueorangutan package

blueorangutan · 2024-08-23T05:48:03Z

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-08-23T06:46:56Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10770

harikrishna-patnala · 2024-08-23T07:00:32Z

@blueorangutan test

blueorangutan · 2024-08-23T07:02:04Z

@harikrishna-patnala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-08-23T22:39:09Z

[SF] Trillian test result (tid-11154)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53649 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9543-t11154-kvm-ol8.zip
Smoke tests completed. 138 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_04_deploy_vnf_appliance	`Error`	103.03	test_vnf_templates.py
test_04_deploy_vnf_appliance	`Error`	103.03	test_vnf_templates.py
test_05_delete_vnf_template	`Error`	1.10	test_vnf_templates.py
ContextSuite context=TestVnfTemplates>:teardown	`Error`	2.24	test_vnf_templates.py

DaanHoogland · 2024-08-26T09:02:47Z

@blueorangutan test

blueorangutan · 2024-08-26T09:04:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-08-26T23:49:26Z

[SF] Trillian test result (tid-11180)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 50425 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9543-t11180-kvm-ol8.zip
Smoke tests completed. 139 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

harikrishna-patnala · 2024-08-28T06:53:09Z

@blueorangutan package

blueorangutan · 2024-08-28T06:54:03Z

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sureshanaparti

clgtm

blueorangutan · 2024-08-28T08:01:09Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 10838

sureshanaparti · 2024-08-28T08:57:42Z

@blueorangutan package

blueorangutan · 2024-08-28T09:00:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-08-28T10:23:24Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10839

yadvr · 2024-09-04T06:53:33Z

@blueorangutan test

blueorangutan · 2024-09-04T06:54:04Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-09-04T22:53:01Z

[SF] Trillian test result (tid-11324)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54960 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9543-t11324-kvm-ol8.zip
Smoke tests completed. 138 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_redundant_VPC_default_routes	`Failure`	395.88	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Failure`	488.42	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	488.44	test_vpc_redundant.py

…ache#9543)

Added update, enable, disable events for the primary storage

df62852

boring-cyborg Bot added component:api component:storage labels Aug 19, 2024

harikrishna-patnala added this to the 4.20.0.0 milestone Aug 19, 2024

harikrishna-patnala linked an issue Aug 19, 2024 that may be closed by this pull request

Have an event generated for disable/enable primary storage #8494

Closed

JoaoJandre reviewed Aug 20, 2024

View reviewed changes

code refactoring

35dcb15

kiranchavala approved these changes Aug 21, 2024

View reviewed changes

JoaoJandre approved these changes Aug 21, 2024

View reviewed changes

Allow tags to be empty to remove tags on the primary storage

a923bc3

sureshanaparti reviewed Aug 27, 2024

View reviewed changes

Comment thread server/src/main/java/com/cloud/storage/StorageManagerImpl.java

validate pool ID

fe0a3bd

sureshanaparti approved these changes Aug 28, 2024

View reviewed changes

yadvr approved these changes Sep 4, 2024

View reviewed changes

DaanHoogland merged commit 716ab20 into apache:main Sep 5, 2024

DaanHoogland deleted the PrimaryStorageEvents branch September 5, 2024 06:39

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 6, 2024

Added update, enable, disable events to the updateStoragePool API (ap…

9720b71

…ache#9543)

Uh oh!

Conversation

harikrishna-patnala commented Aug 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

harikrishna-patnala commented Aug 19, 2024

Uh oh!

blueorangutan commented Aug 19, 2024

Uh oh!

codecov Bot commented Aug 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Aug 19, 2024

Uh oh!

JoaoJandre Aug 20, 2024

Choose a reason for hiding this comment

Uh oh!

harikrishna-patnala Aug 21, 2024

Choose a reason for hiding this comment

Uh oh!

harikrishna-patnala commented Aug 21, 2024

Uh oh!

blueorangutan commented Aug 21, 2024

Uh oh!

blueorangutan commented Aug 21, 2024

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

kiranchavala commented Aug 21, 2024

Uh oh!

blueorangutan commented Aug 21, 2024

Uh oh!

JoaoJandre left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Aug 22, 2024

Uh oh!

harikrishna-patnala commented Aug 23, 2024

Uh oh!

harikrishna-patnala commented Aug 23, 2024

Uh oh!

blueorangutan commented Aug 23, 2024

Uh oh!

blueorangutan commented Aug 23, 2024

Uh oh!

harikrishna-patnala commented Aug 23, 2024

Uh oh!

blueorangutan commented Aug 23, 2024

Uh oh!

blueorangutan commented Aug 23, 2024

Uh oh!

DaanHoogland commented Aug 26, 2024

Uh oh!

blueorangutan commented Aug 26, 2024

Uh oh!

blueorangutan commented Aug 26, 2024

Uh oh!

Uh oh!

harikrishna-patnala commented Aug 28, 2024

Uh oh!

blueorangutan commented Aug 28, 2024

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Aug 28, 2024

Uh oh!

sureshanaparti commented Aug 28, 2024

Uh oh!

blueorangutan commented Aug 28, 2024

harikrishna-patnala commented Aug 19, 2024 •

edited

Loading

codecov Bot commented Aug 19, 2024 •

edited

Loading