ui: rename autoscale instance group to simply autoscaling group#9487
Merged
Conversation
This just renames UI label from autoscale instance group to autoscaling group. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Member
Author
|
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9487 +/- ##
============================================
- Coverage 15.54% 15.53% -0.02%
+ Complexity 11976 11974 -2
============================================
Files 5495 5496 +1
Lines 481076 481335 +259
Branches 62235 60355 -1880
============================================
- Hits 74785 74767 -18
- Misses 398028 398303 +275
- Partials 8263 8265 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
FelipeM525
approved these changes
Aug 5, 2024
FelipeM525
left a comment
FelipeM525
left a comment
Contributor
There was a problem hiding this comment.
CLGTM Well done!
Before
After
Member
Author
|
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
weizhouapache
approved these changes
Aug 7, 2024
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Aug 22, 2024
…he#9487) This just renames UI label from autoscale instance group to autoscaling group. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just renames UI label from autoscale instance group to autoscaling group.
Shorter name in the UI menu/navigation makes it break less on some screens.
This was suggested by @msinhore
Types of changes