Updated invalid parameter/value error with proper exception by sureshanaparti · Pull Request #9455 · apache/cloudstack

sureshanaparti · 2024-07-26T10:53:53Z

Description

This PR updates invalid parameter/value error with proper exception, to com.cloud.exception.InvalidParameterValueException (from java.security.InvalidParameterException).

Fixes #9436

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

…erValueException

sureshanaparti · 2024-07-26T10:55:06Z

@blueorangutan package

blueorangutan · 2024-07-26T10:56:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-07-26T11:03:17Z

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 15.54%. Comparing base (d41dc17) to head (1af6b54).
Report is 65 commits behind head on main.

Files	Patch %	Lines
...loud/network/lb/LoadBalancingRulesManagerImpl.java	0.00%	13 Missing ⚠️
...udstack/storage/datastore/util/ElastistorUtil.java	0.00%	8 Missing ⚠️
...ain/java/com/cloud/network/NetworkServiceImpl.java	0.00%	7 Missing ⚠️
...oud/hypervisor/vmware/mo/HypervisorHostHelper.java	0.00%	5 Missing ⚠️
.../main/java/com/cloud/network/NetworkModelImpl.java	0.00%	4 Missing ⚠️
...daylight/agent/OpenDaylightControllerResource.java	0.00%	2 Missing ⚠️
...oudstack/api/command/user/vm/GetVMPasswordCmd.java	0.00%	1 Missing ⚠️
...va/org/apache/cloudstack/kvm/ha/KVMHAProvider.java	0.00%	1 Missing ⚠️
.../org/apache/cloudstack/ha/SimulatorHAProvider.java	0.00%	1 Missing ⚠️
...kubernetes/cluster/CreateKubernetesClusterCmd.java	0.00%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@             Coverage Diff             @@
##               main    #9455     +/-   ##
===========================================
  Coverage     15.54%   15.54%             
+ Complexity    11977    11976      -1     
===========================================
  Files          5494     5494             
  Lines        481055   481056      +1     
  Branches      60787    58888   -1899     
===========================================
+ Hits          74771    74776      +5     
+ Misses       398022   398018      -4     
  Partials       8262     8262

Flag	Coverage Δ
uitests	`4.18% <ø> (ø)`
unittests	`16.31% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-07-26T12:01:35Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10484

weizhouapache

thanks @sureshanaparti
lgtm

sureshanaparti · 2024-07-26T13:16:46Z

@blueorangutan test

blueorangutan · 2024-07-26T13:18:03Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

sureshanaparti · 2024-07-29T06:32:39Z

@blueorangutan test

blueorangutan · 2024-07-29T06:34:03Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

FelipeM525

LGTM!

weizhouapache · 2024-08-02T14:54:00Z

@blueorangutan package

blueorangutan · 2024-08-02T14:56:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-08-02T16:03:09Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10552

DaanHoogland

clgtm

DaanHoogland · 2024-08-12T12:30:31Z

@blueorangutan test

blueorangutan · 2024-08-12T12:32:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-08-13T04:57:28Z

[SF] Trillian test result (tid-11058)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56728 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9455-t11058-kvm-ol8.zip
Smoke tests completed. 134 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_secured_to_nonsecured_vm_migration	`Error`	427.70	test_vm_life_cycle.py
test_02_redundant_VPC_default_routes	`Failure`	450.80	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Failure`	531.89	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	531.91	test_vpc_redundant.py
test_02_VPC_default_routes	`Failure`	198.48	test_vpc_router_nics.py

sureshanaparti · 2024-08-27T13:45:26Z

@blueorangutan package

blueorangutan · 2024-08-27T13:46:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-08-27T14:47:51Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10827

sureshanaparti · 2024-08-27T14:50:50Z

@blueorangutan test

blueorangutan · 2024-08-27T14:52:03Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-08-28T05:52:11Z

[SF] Trillian test result (tid-11201)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51791 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9455-t11201-kvm-ol8.zip
Smoke tests completed. 138 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_redundant_vpc_site2site_vpn	`Failure`	434.50	test_vpc_vpn.py

sureshanaparti · 2024-08-28T06:53:51Z

[SF] Trillian test result (tid-11201) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 51791 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9455-t11201-kvm-ol8.zip Smoke tests completed. 138 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_redundant_vpc_site2site_vpn Failure 434.50 test_vpc_vpn.py

failure not related to the changes here

…erValueException (apache#9455)

Updated invalid parameter/value to com.cloud.exception.InvalidParamet…

1af6b54

…erValueException

boring-cyborg Bot added component:api component:kubernetes component:kvm component:networking component:primary-storage component:simulator component:storage component:vmware labels Jul 26, 2024

sureshanaparti mentioned this pull request Jul 26, 2024

Some java classes use "java.security.InvalidParameterException" which should be "com.cloud.exception.InvalidParameterValueException" #9436

Closed

sureshanaparti requested review from DaanHoogland and weizhouapache July 26, 2024 10:54

sureshanaparti added this to the 4.20.0.0 milestone Jul 26, 2024

sureshanaparti changed the title ~~Updated invalid parameter/value to com.cloud.exception.InvalidParameterValueException~~ Updated invalid parameter/value exception to com.cloud.exception.InvalidParameterValueException (from java.security.InvalidParameterException) Jul 26, 2024

weizhouapache approved these changes Jul 26, 2024

View reviewed changes

FelipeM525 approved these changes Aug 2, 2024

View reviewed changes

DaanHoogland changed the title ~~Updated invalid parameter/value error with proper exception, to com.cloud.exception.InvalidParameterValueException (from java.security.InvalidParameterException)~~ Updated invalid parameter/value error with proper exception Aug 12, 2024

DaanHoogland approved these changes Aug 12, 2024

View reviewed changes

DaanHoogland merged commit c05edc4 into apache:main Aug 28, 2024

DaanHoogland deleted the parameter-exception-fix branch August 28, 2024 06:54

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 30, 2024

Updated invalid parameter/value to com.cloud.exception.InvalidParamet…

dcc4052

…erValueException (apache#9455)

Uh oh!

Conversation

sureshanaparti commented Jul 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented Jul 26, 2024

Uh oh!

blueorangutan commented Jul 26, 2024

Uh oh!

codecov Bot commented Jul 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jul 26, 2024

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Jul 26, 2024

Uh oh!

blueorangutan commented Jul 26, 2024

Uh oh!

sureshanaparti commented Jul 29, 2024

Uh oh!

blueorangutan commented Jul 29, 2024

Uh oh!

FelipeM525 left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Aug 2, 2024

Uh oh!

blueorangutan commented Aug 2, 2024

Uh oh!

blueorangutan commented Aug 2, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Aug 12, 2024

Uh oh!

blueorangutan commented Aug 12, 2024

Uh oh!

blueorangutan commented Aug 13, 2024

Uh oh!

sureshanaparti commented Aug 27, 2024

Uh oh!

blueorangutan commented Aug 27, 2024

Uh oh!

blueorangutan commented Aug 27, 2024

Uh oh!

sureshanaparti commented Aug 27, 2024

Uh oh!

blueorangutan commented Aug 27, 2024

Uh oh!

blueorangutan commented Aug 28, 2024

Uh oh!

sureshanaparti commented Aug 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sureshanaparti commented Jul 26, 2024 •

edited

Loading

codecov Bot commented Jul 26, 2024 •

edited

Loading