Skip to content

packaging: bundle latest cmk x86 build with deb and rpm packages#9450

Merged
yadvr merged 7 commits into
apache:mainfrom
shapeblue:cmk-latest-bundle
Jul 30, 2024
Merged

packaging: bundle latest cmk x86 build with deb and rpm packages#9450
yadvr merged 7 commits into
apache:mainfrom
shapeblue:cmk-latest-bundle

Conversation

@yadvr

@yadvr yadvr commented Jul 26, 2024

Copy link
Copy Markdown
Member

This uses the latest tag to find and use the latest Github tag from cloudstack-cloudmonkey repo, and use that to bundle the binary CLI in packages.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

@yadvr
packaging: bundle latest cmk x86 build with deb and rpm packages
0965634 
This uses the latest tag to find and use the latest Github tag from
cloudstack-cloudmonkey repo, and use that to bundle the binary CLI in
packages.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.20.0.0 milestone Jul 26, 2024
@yadvr

yadvr commented Jul 26, 2024

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

blueorangutan commented Jul 26, 2024

Copy link
Copy Markdown

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Jul 26, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.54%. Comparing base (817251f) to head (9360ff3).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##               main    #9450    +/-   ##
==========================================
  Coverage     15.54%   15.54%            
  Complexity    11976    11976            
==========================================
  Files          5494     5495     +1     
  Lines        481056   481076    +20     
  Branches      59747    58865   -882     
==========================================
+ Hits          74770    74781    +11     
- Misses       398024   398033     +9     
  Partials       8262     8262
Flag Coverage Δ
uitests 4.21% <ø> (+0.02%) ⬆️
unittests 16.31% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shwstppr
shwstppr approved these changes Jul 26, 2024
View reviewed changes

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

@blueorangutan

blueorangutan commented Jul 26, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 10477

weizhouapache
weizhouapache reviewed Jul 26, 2024
View reviewed changes
Comment thread debian/rules Outdated
@apache apache deleted a comment from blueorangutan Jul 26, 2024
@apache apache deleted a comment from blueorangutan Jul 26, 2024
@yadvr

yadvr commented Jul 26, 2024

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

blueorangutan commented Jul 26, 2024

Copy link
Copy Markdown

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jul 26, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 10483

@yadvr
shell workaround
3e734f2 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr

yadvr commented Jul 26, 2024

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

blueorangutan commented Jul 26, 2024

Copy link
Copy Markdown

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jul 26, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10486

@yadvr yadvr requested a review from weizhouapache July 29, 2024 04:06
sureshanaparti
sureshanaparti reviewed Jul 29, 2024
View reviewed changes
Comment thread debian/rules Outdated
sureshanaparti
sureshanaparti approved these changes Jul 29, 2024
View reviewed changes

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

weizhouapache
weizhouapache reviewed Jul 29, 2024
View reviewed changes
Comment thread packaging/centos8/cloud.spec Outdated
@weizhouapache

weizhouapache commented Jul 29, 2024

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Jul 29, 2024

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jul 29, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10503

kiranchavala
kiranchavala approved these changes Jul 29, 2024
View reviewed changes

@kiranchavala kiranchavala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Cmk binary is present in the installation

[root@ref-trl-7061-k-Mr8-kiran-chavala-mgmt1 ~]# which cmk
/usr/bin/cmk


[root@ref-trl-7061-k-Mr8-kiran-chavala-mgmt1 ~]# cmk
Apache CloudStack 🐵 CloudMonkey 6.4.0
Report issues: https://github.com/apache/cloudstack-cloudmonkey/issues

(localcloud) 🐱 >

@yadvr yadvr merged commit 7214c13 into apache:main Jul 30, 2024
@yadvr yadvr deleted the cmk-latest-bundle branch July 30, 2024 04:31
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 31, 2024
@yadvr @weizhouapache @dhslove
packaging: bundle latest cmk x86 build with deb and rpm packages (apa…
9473dfc 
…che#9450)

This uses the latest tag to find and use the latest Github tag from
cloudstack-cloudmonkey repo, and use that to bundle the binary CLI in
packages.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Co-authored-by: Wei Zhou <weizhou@apache.org>
@JoaoJandre JoaoJandre mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weizhouapache weizhouapache weizhouapache left review comments
@shwstppr shwstppr shwstppr approved these changes
@kiranchavala kiranchavala kiranchavala approved these changes
@sureshanaparti sureshanaparti sureshanaparti approved these changes
@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala
@vladimirpetrov vladimirpetrov Awaiting requested review from vladimirpetrov

Assignees

@kiranchavala kiranchavala

Labels

component:packaging distro:centos distro:ubuntu

Projects

None yet

Milestone

4.20.0

Development

Successfully merging this pull request may close these issues.

6 participants

@yadvr @blueorangutan @weizhouapache @shwstppr @kiranchavala @sureshanaparti