Skip to content

Display associated resource name on storage pools objects#9449

Merged
yadvr merged 1 commit into
apache:mainfrom
shapeblue:420-liststoragepool-addresourcenames
Sep 5, 2024
Merged

Display associated resource name on storage pools objects#9449
yadvr merged 1 commit into
apache:mainfrom
shapeblue:420-liststoragepool-addresourcenames

Conversation

@nvazquez

Copy link
Copy Markdown
Contributor

Description

This PR adds the resource name for templates, volumes and snapshots on the listStoragePoolObjects API response and displays them UI under the Associated Resource column on the Storage Pool Browser section

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before the fix:
Screenshot 2024-07-25 at 18 37 34

After the fix:
Screenshot 2024-07-25 at 18 50 37

How Has This Been Tested?

Tested for Primary and Secondary Storage pools

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Jul 25, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.

Project coverage is 15.54%. Comparing base (1662af1) to head (f87ac89).
Report is 104 commits behind head on main.

Files with missing lines Patch % Lines
...stack/storage/browser/DataStoreObjectResponse.java 33.33% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##               main    #9449     +/-   ##
===========================================
  Coverage     15.54%   15.54%             
  Complexity    11976    11976             
===========================================
  Files          5494     5494             
  Lines        481056   481080     +24     
  Branches      61139    58636   -2503     
===========================================
+ Hits          74770    74788     +18     
- Misses       398024   398030      +6     
  Partials       8262     8262             
Flag Coverage Δ
uitests 4.18% <ø> (ø)
unittests 16.31% <57.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nvazquez

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10473

@FelipeM525 FelipeM525 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR in a local environment and everything seems to be working fine.

Primary Storage

image

Secondary Storage

image

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm and I like the functionality. It does seem like a backwards incompatible change. Should we make it optional (/me being nitpicking)?

@yadvr yadvr added this to the 4.20.0.0 milestone Sep 4, 2024
@yadvr

yadvr commented Sep 4, 2024

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10945

@yadvr

yadvr commented Sep 4, 2024

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-11336)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55612 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9449-t11336-kvm-ol8.zip
Smoke tests completed. 139 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@yadvr yadvr merged commit 36d37f7 into apache:main Sep 5, 2024
@yadvr yadvr deleted the 420-liststoragepool-addresourcenames branch September 5, 2024 04:09
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants