test: improve purge expunged resources b/g task testcase#9426
Merged
Conversation
Failures were seen for during purging of expunged resources via bacground task during different test runs. This PR tries to make sure b/g task execution is not skipped after MS restrat in a multi-MS environment. It also updates expunged.resources.purge.interval to allow running task again in 60s. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
boring-cyborg
Bot
added
component:integration-test
Python
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9426 +/- ##
===========================================
Coverage 15.54% 15.54%
Complexity 11977 11977
===========================================
Files 5494 5494
Lines 481055 481055
Branches 60787 59679 -1108
===========================================
Hits 74771 74771
Misses 398022 398022
Partials 8262 8262
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
yadvr
approved these changes
Jul 22, 2024
DaanHoogland
approved these changes
Jul 22, 2024
DaanHoogland
left a comment
DaanHoogland
left a comment
Contributor
There was a problem hiding this comment.
we should be able to use modern string formatting. other than that LGTM
| logging.info("Waiting for 2x%d = %d seconds for background task to execute" % (purge_task_delay, wait)) | ||
| wait_multiple = 2 | ||
| wait = wait_multiple * purge_task_delay | ||
| logging.info("Waiting for %dx%d = %d seconds for background task to execute" % (wait_multiple, purge_task_delay, wait)) |
Contributor
There was a problem hiding this comment.
Suggested change
| logging.info("Waiting for %dx%d = %d seconds for background task to execute" % (wait_multiple, purge_task_delay, wait)) | |
| logging.info(f"Waiting for {wait_multiple}x{purge_task_delay} = {wait} seconds for background task to execute") |
| return False | ||
| self.debug("Restarting all management server") | ||
| for idx, server_ip in enumerate(server_ips): | ||
| self.debug("Restarting management server #%d with IP %s" % (idx, server_ip)) |
Contributor
There was a problem hiding this comment.
Suggested change
| self.debug("Restarting management server #%d with IP %s" % (idx, server_ip)) | |
| self.debug(f"Restarting management server #{idx} with IP {server_ip}") |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10435 |
Contributor
|
@blueorangutan test matrix |
|
@DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-10937)
|
|
[SF] Trillian test result (tid-10939)
|
|
[SF] Trillian test result (tid-10938)
|
Contributor
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10446 |
Contributor
|
@blueorangutan test matrix |
|
@DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-10951) |
|
[SF] Trillian test result (tid-10952)
|
|
[SF] Trillian test result (tid-10953)
|
Contributor
Author
|
@blueorangutan test alma8 kvm-alma8 |
|
@shwstppr a [SL] Trillian-Jenkins test job (alma8 mgmt + kvm-alma8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-10956)
|
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jul 31, 2024
* test: improve purge expunged resources b/g task testcase Failures were seen for during purging of expunged resources via bacground task during different test runs. This PR tries to make sure b/g task execution is not skipped after MS restrat in a multi-MS environment. It also updates expunged.resources.purge.interval to allow running task again in 60s. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * new string formatting --------- Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Failures were seen for during purging of expunged resources via bacground task during different test runs. This PR tries to make sure b/g task execution is not skipped after MS restrat in a multi-MS environment. It also updates expunged.resources.purge.interval to allow running task again in 60s.
#9316 (comment)
#9316 (comment)
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?