Skip to content

Icon changed for control-outlined#9402

Merged
DaanHoogland merged 1 commit into
apache:mainfrom
scclouds:PR-change-hosts-Oobm-maintenance-icon
Jul 17, 2024
Merged

Icon changed for control-outlined#9402
DaanHoogland merged 1 commit into
apache:mainfrom
scclouds:PR-change-hosts-Oobm-maintenance-icon

Conversation

@LayonRibeiro

@LayonRibeiro LayonRibeiro commented Jul 16, 2024

Copy link
Copy Markdown
Contributor

Description

On the hosts details page, icons with distinct functionalities currently share the same image. This PR aims to enhance the user experience by proposing a change to differentiate the icons Start rolling maintenance and Configure out-of-band management on the hosts details page.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Hosts page before changes
image

Hosts page after changes
image

How Has This Been Tested?

After the UI change, the icon for Start rolling maintenance has been updated and is now reflected in the UI as well

@boring-cyborg

boring-cyborg Bot commented Jul 16, 2024

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

@codecov

codecov Bot commented Jul 17, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.54%. Comparing base (afdf4d7) to head (dff1c55).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9402      +/-   ##
============================================
- Coverage     15.54%   15.54%   -0.01%     
+ Complexity    11976    11975       -1     
============================================
  Files          5493     5493              
  Lines        481030   481030              
  Branches      60247    59494     -753     
============================================
- Hits          74766    74764       -2     
- Misses       398000   398004       +4     
+ Partials       8264     8262       -2     
Flag Coverage Δ
uitests 4.16% <ø> (ø)
unittests 16.31% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9402 (QA-JID-406)

@FelipeM525 FelipeM525 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it LGTM!

Before

image

After

image

@DaanHoogland DaanHoogland merged commit 56c661c into apache:main Jul 17, 2024
@boring-cyborg

boring-cyborg Bot commented Jul 17, 2024

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request!

@yadvr yadvr added this to the 4.20.0.0 milestone Jul 17, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants