Skip to content

linstor: deleteAsync fallback to volume UUID if path not set yet#9325

Merged
sureshanaparti merged 1 commit into
apache:4.18from
LINBIT:linstor-4.18-fix-delete-without-path-set
Jul 4, 2024
Merged

linstor: deleteAsync fallback to volume UUID if path not set yet#9325
sureshanaparti merged 1 commit into
apache:4.18from
LINBIT:linstor-4.18-fix-delete-without-path-set

Conversation

@rp-

@rp- rp- commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

Description

If Linstor resource creation failed before volume.setPath() was called/stored, path will be null
and cleanup attempt for that resource from CloudStack will fail (because there is no cs-null resource).

This PR now fallback to the volume.uuid if path wasn't set yet.

Partially fixes an issue from #9321

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested deleting volumes on a fresh Linstor/CloudStack cluster.

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Jul 2, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 12.24%. Comparing base (983f164) to head (08cdb99).

Files Patch % Lines
...tore/driver/LinstorPrimaryDataStoreDriverImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##               4.18    #9325    +/-   ##
==========================================
  Coverage     12.24%   12.24%            
- Complexity     9295     9296     +1     
==========================================
  Files          4699     4699            
  Lines        414347   414348     +1     
  Branches      50906    51267   +361     
==========================================
+ Hits          50731    50738     +7     
+ Misses       357311   357305     -6     
  Partials       6305     6305
Flag Coverage Δ
unittests 12.24% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland

DaanHoogland commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

@rp- is this critical (or is there a work around)? cc @sureshanaparti

DaanHoogland
DaanHoogland approved these changes Jul 2, 2024
View reviewed changes

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

sureshanaparti
sureshanaparti approved these changes Jul 2, 2024
View reviewed changes

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti

sureshanaparti commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

blueorangutan commented Jul 2, 2024

Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@rp-

rp- commented Jul 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@rp- is this critical (or is there a work around)? cc @sureshanaparti

not critical, as it shouldn't happen in 95% of installs

@blueorangutan

blueorangutan commented Jul 2, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10231

@DaanHoogland DaanHoogland added this to the 4.19.2.0 milestone Jul 2, 2024
@DaanHoogland

DaanHoogland commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

blueorangutan commented Jul 2, 2024

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Jul 2, 2024

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-10713)

@DaanHoogland DaanHoogland linked an issue Jul 3, 2024 that may be closed by this pull request
Re-deploy SystemVMs not working #9321
Closed
@yadvr yadvr modified the milestones: 4.19.2.0, 4.19.1.0 Jul 4, 2024
@sureshanaparti

sureshanaparti commented Jul 4, 2024

Copy link
Copy Markdown
Contributor

Changes in Linstor provider, Merging based on reviews & maintainer tests.

@sureshanaparti sureshanaparti merged commit eb1a0ef into apache:4.18 Jul 4, 2024
@rp- rp- deleted the linstor-4.18-fix-delete-without-path-set branch July 4, 2024 13:04
vishesh92 added a commit that referenced this pull request Jul 5, 2024
@vishesh92
Merge release branch 4.18 to 4.19
ba85b4d 
* 4.18:
  linstor: deleteAsync fallback to volume UUID if path not set yet (#9325)
  linstor: do not use the same static ApiClient for all calls (#9326)
@DaanHoogland DaanHoogland mentioned this pull request Jul 11, 2024
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 15, 2024
@rp- @dhslove
linstor: deleteAsync fallback to volume UUID if path not set yet (apa…
5bd02e9 
…che#9325)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 15, 2024
@vishesh92 @dhslove
Merge release branch 4.18 to 4.19
683f060 
* 4.18:
  linstor: deleteAsync fallback to volume UUID if path not set yet (apache#9325)
  linstor: do not use the same static ApiClient for all calls (apache#9326)
rp- added a commit to LINBIT/cloudstack that referenced this pull request Aug 21, 2024
@rp-
linstor: deleteAsync fallback to volume UUID if path not set yet (apa…
c54d366 
…che#9325)
rp- added a commit to LINBIT/cloudstack that referenced this pull request Feb 24, 2026
@rp-
linstor: deleteAsync fallback to volume UUID if path not set yet (apa…
6a2820e 
…che#9325)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes
@DaanHoogland DaanHoogland DaanHoogland approved these changes
@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees

No one assigned

Labels

3rd-party:linstor component:primary-storage component:storage has-3rdparty-components

Projects

No open projects
Apache CloudStack 4.19.1
Status: Done

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

Re-deploy SystemVMs not working

5 participants

@rp- @DaanHoogland @sureshanaparti @blueorangutan @yadvr