Add action button to enable/disable Oauth provider#9242
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9242 +/- ##
============================================
- Coverage 14.96% 14.95% -0.01%
+ Complexity 11013 11011 -2
============================================
Files 5377 5378 +1
Lines 469567 469808 +241
Branches 60162 58662 -1500
============================================
- Hits 70285 70279 -6
- Misses 391498 391745 +247
Partials 7784 7784
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
LGTM |
|
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@blueorangutan package |
|
@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
@blueorangutan package |
|
@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9941 |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9943 |
kiranchavala
left a comment
There was a problem hiding this comment.
LGTM,
Before the fix, disable/enable the oauth provider was in the form
After the fix disable/enable is moved to the top right corner action item
Also the extra spaces were removed
Before the fix, if the credentials contained a trailing space at the end, they were passed
After the fix , the trailing spaces are removed
|
@blueorangutan test |
|
@kiranchavala a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-10444)
|




Description
Fixes: #8501
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?