Skip to content

Add action button to enable/disable Oauth provider#9242

Merged
DaanHoogland merged 3 commits into
apache:4.19from
abh1sar:oauth-enable-disable
Jun 18, 2024
Merged

Add action button to enable/disable Oauth provider#9242
DaanHoogland merged 3 commits into
apache:4.19from
abh1sar:oauth-enable-disable

Conversation

@abh1sar

@abh1sar abh1sar commented Jun 13, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes: #8501

  1. Action button to enable/disable Oauth2 provider
  2. Trim extra spaces from clientid, uri and secretkey

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot from 2024-06-13 14-02-12
Screenshot from 2024-06-13 14-02-24
Screenshot from 2024-06-13 14-02-46
Screenshot from 2024-06-13 14-02-57

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Jun 13, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.95%. Comparing base (b2ef53b) to head (b24e990).
Report is 16 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9242      +/-   ##
============================================
- Coverage     14.96%   14.95%   -0.01%     
+ Complexity    11013    11011       -2     
============================================
  Files          5377     5378       +1     
  Lines        469567   469808     +241     
  Branches      60162    58662    -1500     
============================================
- Hits          70285    70279       -6     
- Misses       391498   391745     +247     
  Partials       7784     7784              
Flag Coverage Δ
uitests 4.29% <ø> (-0.01%) ⬇️
unittests 15.67% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland DaanHoogland linked an issue Jun 13, 2024 that may be closed by this pull request

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@yadvr yadvr added this to the 4.19.1.0 milestone Jun 13, 2024
@yadvr

yadvr commented Jun 13, 2024

Copy link
Copy Markdown
Member

LGTM
@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9242 (QA-JID-377)

@kiranchavala

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@abh1sar

abh1sar commented Jun 14, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9941

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9943

@kiranchavala kiranchavala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Before the fix, disable/enable the oauth provider was in the form

296233267-7ac42e71-a006-42a5-a425-633ecd9fdc19

After the fix disable/enable is moved to the top right corner action item

enable:disable


Also the extra spaces were removed

Before the fix, if the credentials contained a trailing space at the end, they were passed

Screenshot 2024-06-13 at 1 49 36 PM

After the fix , the trailing spaces are removed

Screenshot 2024-06-14 at 1 11 37 PM

@kiranchavala

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@kiranchavala a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-10444)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43513 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9242-t10444-kvm-centos7.zip
Smoke tests completed. 131 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland merged commit 591cc4f into apache:4.19 Jun 18, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 20, 2024
@abh1sar abh1sar deleted the oauth-enable-disable branch June 20, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Ui improvements to OAuth Configuration

6 participants