Fix unit test failure in LibvirtConvertInstanceCommandWrapperTest#9238
Merged
Conversation
Member
Author
|
@blueorangutan package |
|
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9238 +/- ##
============================================
+ Coverage 4.29% 14.96% +10.67%
- Complexity 0 11017 +11017
============================================
Files 363 5377 +5014
Lines 29356 469586 +440230
Branches 5128 58816 +53688
============================================
+ Hits 1261 70297 +69036
- Misses 27952 391502 +363550
- Partials 143 7787 +7644
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9916 |
yadvr
approved these changes
Jun 13, 2024
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a unit test failure in LibvirtConvertInstanceCommandWrapperTest.
Before this patch,
testGetUnmanagedInstanceDiskscalls thegetNfsStoragePoolHostAndPathmethod which then callsmount | grep null. If the system running test has some mounts with the textnullin them, the test fails.This PR fixes this by mocking the return value for
getNfsStoragePoolHostAndPath.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?