Upload volume format check with the supported hypervisor, fail if supported hypervisor not found on zone

[sureshanaparti]

Description

This PR checks the upload volume format with the supported hypervisor, fail if supported hypervisor not found on zone.

Fixes #8652

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Manually tested upload RAW volume from local.

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.30%. Comparing base (edf7394) to head (401b100).

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #9224       +/-   ##
============================================
- Coverage     14.96%   4.30%   -10.67%     
============================================
  Files          5373     363     -5010     
  Lines        469311   29312   -439999     
  Branches      57432    5118    -52314     
============================================
- Hits          70230    1261    -68969     
+ Misses       391307   27908   -363399     
+ Partials       7774     143     -7631     

Flag	Coverage Δ
uitests	4.30% <ø> (ø)
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9871

[vladimirpetrov]

LGTM based on manual testing. Tested with RAW, VHD and OVA volumes on KVM hypervisor and RAW, VHD and QCOW2 on VMWare.

[DaanHoogland]

should we still call sanitizeFormat?

[sureshanaparti]

yes @DaanHoogland, it's called before. this is duplicate call. so removed

cloudstack/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

Line 413 in edf7394

String format = sanitizeFormat(cmd.getFormat());

cloudstack/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

Line 455 in edf7394

String format = sanitizeFormat(cmd.getFormat());

[DaanHoogland]

clgtm