kvm: fix ide controller for rocky/alma vms

[weizhouapache]

Description

This PR fixes ide controller for rocky/alma vms. virtio devices should be used.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a2dbeb) 13.10% compared to head (f8f1f35) 13.11%.
Report is 3 commits behind head on 4.18.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.18    #8247      +/-   ##
============================================
+ Coverage     13.10%   13.11%   +0.01%     
- Complexity     9122     9133      +11     
============================================
  Files          2720     2720              
  Lines        257638   257645       +7     
  Branches      40168    40171       +3     
============================================
+ Hits          33753    33800      +47     
+ Misses       219619   219554      -65     
- Partials       4266     4291      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7842

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-8402)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40207 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8247-t8402-kvm-centos7.zip
Smoke tests completed. 108 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_migrate_vm	Error	0.04	test_vm_life_cycle.py

[DaanHoogland]

clgtm

[weizhouapache]

I have manually tested this PR as well.
The rocky 8 vm is configured correctly to use virtio drivers instead of legacy ide disk and e1000 nic adaptor.

However, I am the author of this PR, :-D

[DaanHoogland]

deployed a vm on alma8:

    <disk type='file' device='disk'>
      <driver name='qemu' type='qcow2' cache='none'/>
      <source file='/mnt/ba13d800-c167-33b1-8419-b4eae4573077/85286552-202c-4894-8e55-26a335a4f4de' index='1'/>
      <backingStore/>
      <target dev='vdb' bus='virtio'/>
      <serial>85286552202c48948e55</serial>
      <alias name='virtio-disk1'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/>
    </disk>

@weizhouapache it is correct that the root disk is still on ide?

[weizhouapache]

deployed a vm on alma8:

    <disk type='file' device='disk'>
      <driver name='qemu' type='qcow2' cache='none'/>
      <source file='/mnt/ba13d800-c167-33b1-8419-b4eae4573077/85286552-202c-4894-8e55-26a335a4f4de' index='1'/>
      <backingStore/>
      <target dev='vdb' bus='virtio'/>
      <serial>85286552202c48948e55</serial>
      <alias name='virtio-disk1'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/>
    </disk>

@weizhouapache it is correct that the root disk is still on ide?

root disk should be virtio disk as well
@DaanHoogland

[DaanHoogland]

root disk should be virtio disk as well

ok, not in my test

    <disk type='file' device='disk'>
      <driver name='qemu' type='qcow2' cache='none'/>
      <source file='/mnt/ba13d800-c167-33b1-8419-b4eae4573077/5c705d82-3ed5-40bc-9430-edd4d109d82e' index='3'/>
      <backingStore type='file' index='4'>
        <format type='qcow2'/>
        <source file='/mnt/ba13d800-c167-33b1-8419-b4eae4573077/6afa20c4-3237-4af1-ab2f-7cd1b4082c12'/>
        <backingStore/>
      </backingStore>
      <target dev='hda' bus='ide'/>
      <serial>5c705d823ed540bc9430</serial>
      <alias name='ide0-0-0'/>
      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
    </disk>
    <disk type='file' device='cdrom'>
      <driver name='qemu'/>
      <target dev='hdc' bus='ide'/>
      <readonly/>
      <alias name='ide0-1-0'/>
      <address type='drive' controller='0' bus='1' target='0' unit='0'/>
    </disk>

[shwstppr]

Code LGTM

[shwstppr]

@DaanHoogland @weizhouapache is this good to go or are there some deviations in the manual tests here, #8247 (comment)?

[DaanHoogland]

@DaanHoogland @weizhouapache is this good to go or are there some deviations in the manual tests here, #8247 (comment)?

I did not investigate further why this happened. @weizhouapache can you comment?

[DaanHoogland]

ok, this was layer 8 issue. I discussed with @weizhouapache off line and all lgtm @shwstppr