Fix typo in ssvm check script

[slavkap]

Description

This PR fixes a typo, which causes an incorrect check for the NFS connection.

ERROR: Storage nfs is not currently mounted
Verifying if we can at least ping the storage
Storage address is empty, trying to ping storage network gateway instead ()
ping: missing host operand
Try 'ping --help' or 'ping --usage' for more information.
WARNING: Cannot ping nfs storage network gateway

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

[yadvr]

LGTM - didn't check/test

[DaanHoogland]

clgtm

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Merging #8191 (63199dd) into 4.18 (e6f048b) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.18    #8191      +/-   ##
============================================
- Coverage     13.07%   13.07%   -0.01%     
+ Complexity     9111     9110       -1     
============================================
  Files          2720     2720              
  Lines        257597   257597              
  Branches      40160    40160              
============================================
- Hits          33680    33671       -9     
- Misses       219682   219692      +10     
+ Partials       4235     4234       -1     

see 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7661

[DaanHoogland]

@slavkap I try to validate your PR but don't see the error on 4.18-HEAD

[DaanHoogland]

but I got exactly the same output with it so at least no regression:

can you expand on why you have this issue @slavkap ? mine seems to silently fail (or not fail at all????)

[slavkap]

@DaanHoogland, I'm having this issue when there is a problem with the NFS, and it's not mounted.

[DaanHoogland]

@DaanHoogland, I'm having this issue when there is a problem with the NFS, and it's not mounted.

of course :headbang:

[blueorangutan]

[LL]Trillian test result (tid-6887)
Environment: kvm-centos7 (x1), Advanced Networking with Mgmt server 7
Total time taken: 40150 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8191-t6887-kvm-centos7.zip
Smoke tests completed. 104 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_DeployVmAntiAffinityGroup	Error	35.44	test_affinity_groups.py
test_DeployVmAntiAffinityGroup_in_project	Error	71.37	test_affinity_groups_projects.py
test_01_non_strict_host_anti_affinity	Failure	100.37	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	Error	77.92	test_nonstrict_affinity_group.py
test_02_upgrade_kubernetes_cluster	Failure	3925.07	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	Failure	206.65	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	0.03	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.03	test_kubernetes_clusters.py
test_hostha_enable_ha_when_host_in_maintenance	Error	305.69	test_hostha_kvm.py

[shwstppr]

Code change LGTM

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7814

[shwstppr]

@blueorangutan test

[blueorangutan]

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-8388)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 54459 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8191-t8388-kvm-centos7.zip
Smoke tests completed. 108 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	Failure	3616.30	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	Failure	3615.55	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	Failure	0.04	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	Failure	0.04	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	Failure	0.04	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	Failure	0.04	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	Failure	47.70	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	98.89	test_kubernetes_clusters.py