make sure vmware adapter detail for nic is passed during registering template#8173
Conversation
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report
@@ Coverage Diff @@
## 4.18 #8173 +/- ##
=========================================
Coverage 13.06% 13.07%
- Complexity 9111 9113 +2
=========================================
Files 2720 2720
Lines 257592 257592
Branches 40158 40158
=========================================
+ Hits 33663 33674 +11
+ Misses 219698 219685 -13
- Partials 4231 4233 +2 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@andrijapanicsb , low prio but you want this! ;) |
shwstppr
left a comment
shwstppr
left a comment
There was a problem hiding this comment.
Change at line 231 looks good. Rest seems refactoring
that's right @shwstppr , but the renaming of values to formvalues is because of a name clash that i encountered debugging. The fetchNicAdapterTypes() changes are pure refactoring. |
|
@blueorangutan package |
|
@rajujith a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7674 |
rajujith
left a comment
rajujith
left a comment
There was a problem hiding this comment.
LGTM. Verified that the NIC Adapter setting 'vmxnet3' input in the template registration form is retained in the template settings.
DaanHoogland
deleted the
7864-vmware-adapter-detail-not-passed-during-registering-template
branch
5 participants
Description
This PR Fixes: #7864
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
debugged in local UI against lab environment.
Note that this is a pure UI change but is dependend on the template being for vmware and thus can not be tested in the qa env (which is simulator only).