Skip to content

ui: update vm deploy form iso label#8075

Merged
DaanHoogland merged 1 commit into
apache:4.18from
shapeblue:fix-ui-vmdeploy-myiso
Oct 11, 2023
Merged

ui: update vm deploy form iso label#8075
DaanHoogland merged 1 commit into
apache:4.18from
shapeblue:fix-ui-vmdeploy-myiso

Conversation

@shwstppr

Copy link
Copy Markdown
Contributor

Description

Fixes #8051

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Screenshot from 2023-10-11 13-26-40

Fixes apache#8051

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Oct 11, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8075 (25a4270) into main (864a195) will increase coverage by 16.06%.
Report is 237 commits behind head on main.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##               main    #8075       +/-   ##
=============================================
+ Coverage     13.06%   29.13%   +16.06%     
- Complexity     9108    30381    +21273     
=============================================
  Files          2720     5101     +2381     
  Lines        257537   358712   +101175     
  Branches      40156    52349    +12193     
=============================================
+ Hits          33658   104509    +70851     
- Misses       219649   239834    +20185     
- Partials       4230    14369    +10139     
Flag Coverage Δ
simulator-marvin-tests 25.08% <ø> (?)
uitests 4.84% <0.00%> (?)
unit-tests 14.51% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../src/views/compute/wizard/TemplateIsoSelection.vue 0.00% <0.00%> (ø)

... and 3669 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8075 (QA-JID-199)

@shwstppr shwstppr requested a review from kiranchavala October 11, 2023 08:45
@shwstppr shwstppr added this to the 4.18.2.0 milestone Oct 11, 2023
@shwstppr shwstppr changed the base branch from main to 4.18 October 11, 2023 12:02
@shwstppr

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8075 (QA-JID-201)

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm &&
image

@DaanHoogland DaanHoogland merged commit 7b4cf1b into apache:4.18 Oct 11, 2023
@DaanHoogland DaanHoogland deleted the fix-ui-vmdeploy-myiso branch October 11, 2023 12:56
rp- pushed a commit to LINBIT/cloudstack that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vm deployment wizard should mention "My iso's

4 participants