load (domains) continuously in dropdown boxes

[DaanHoogland]

Description

This PR attempts to load items (PoC for domains on the network creation tab) in case there is more to load than the default 500 maximum.

This should be generalised to a mechanism that applies to any dropdown UI item, but is now only for a particular instance.

Fixes: #7780

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

create loads of domains 26*((26*3)+26)+1 and in the network create dialog add one by typing a partial name that is beyond the 500 mark. I create domains a-z with subdomain a through z and sub-sub-domain 1st, 2nd and 3rd

What is still missing is searching for the last 3rd for instance. There are 26*26 (676) domains named 3rd, and if I want to select the last one. A thing that may also be missing in the domain overview search and in the results of #7766 , this does address the comment in #7766 (review) but as said, not in a generic way (yet)

[DaanHoogland]

@kiranchavala can you review?

[codecov]

Codecov Report

Merging #7931 (265334c) into main (439d70f) will increase coverage by 1.34%.
Report is 168 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7931      +/-   ##
============================================
+ Coverage     13.06%   14.40%   +1.34%     
- Complexity     9093    10111    +1018     
============================================
  Files          2720     2748      +28     
  Lines        257431   259390    +1959     
  Branches      40141    40381     +240     
============================================
+ Hits          33622    37362    +3740     
+ Misses       219582   217196    -2386     
- Partials       4227     4832     +605     

see 176 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7068

[blueorangutan]

Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6178

[blueorangutan]

[LL] Trillian Build Failed (tid-6743)

[DaanHoogland]

@kiranchavala can you test this?

[kiranchavala]

LGTM, Tested the feature and its working fine, the domains greater than 500 are showing in the drop-down for account and network creation wizard

[shwstppr]

Code LGTM but maybe we can create a new element which allows continuous loading for a given API and can be reused across different forms

[DaanHoogland]

Code LGTM but maybe we can create a new element which allows continuous loading for a given API and can be reused across different forms

that was my thought as well, but this is a larger job as there can be different parameters required and also different indices/display fields. This is a quick fix on request. A more generic solution is desirable, i agree. I sugest we merge (if ok'd) and create a ticket for an improvement, @shwstppr .

[shwstppr]

Code LGTM but maybe we can create a new element which allows continuous loading for a given API and can be reused across different forms

that was my thought as well, but this is a larger job as there can be different parameters required and also different indices/display fields. This is a quick fix on request. A more generic solution is desirable, i agree. I sugest we merge (if ok'd) and create a ticket for an improvement, @shwstppr .

We should merge if no further testing/review needed