System VMs in listHostsMetrics API

[hsato03]

Description

The listHostsMetrics API returns the number of user VMs on the host. Although it doesn't return any data from the system VM instances on it.

Due to this, the systeminstances field was created in the listHostsMetrics API, which returns how many system VMs are running on the host and how many system VMs the host has in total.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

I called the listHostsMetrics API via CloudMonkey and the systeminstances field was filled with the number of system VMs running on the host and the total of system VMs on the host.

[DaanHoogland]

code looks good and good functional enhancement 👍 (not tested yet)

[codecov]

Codecov Report

Merging #7871 (aadf48a) into main (0204377) will increase coverage by 0.00%.
Report is 7 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main    #7871   +/-   ##
=========================================
  Coverage     14.38%   14.39%           
- Complexity    10074    10082    +8     
=========================================
  Files          2747     2747           
  Lines        258922   258944   +22     
  Branches      40318    40324    +6     
=========================================
+ Hits          37246    37266   +20     
+ Misses       216867   216863    -4     
- Partials       4809     4815    +6     

Files Changed	Coverage Δ
.../apache/cloudstack/metrics/MetricsServiceImpl.java	12.28% <0.00%> (-0.15%)	⬇️
...pache/cloudstack/response/HostMetricsResponse.java	12.69% <0.00%> (-0.21%)	⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6799

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7444)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50881 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7871-t7444-kvm-centos7.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	921.37	test_kubernetes_clusters.py

[DaanHoogland]

tested ok

[weizhouapache]

code lgtm