api: Force-stop descriptions

[DaanHoogland]

Description

This PR...

Fixes: #6798

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• api doc

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[weizhouapache]

as far as I know, the vm will be destroyed (force-stopped) on the kvm host as well.
not sure how it works on vmware/xenserver.

[DaanHoogland]

as far as I know, the vm will be destroyed (force-stopped) on the kvm host as well. not sure how it works on vmware/xenserver.

It will be tried, but if it fails it will be marked destroyed anyway. That is the intention of the flag.

[weizhouapache]

as far as I know, the vm will be destroyed (force-stopped) on the kvm host as well. not sure how it works on vmware/xenserver.

It will be tried, but if it fails it will be marked destroyed anyway. That is the intention of the flag.

ok @DaanHoogland
can you copy the description in StopVMCmd.java to other java classes ?

[DaanHoogland]

as far as I know, the vm will be destroyed (force-stopped) on the kvm host as well. not sure how it works on vmware/xenserver.

It will be tried, but if it fails it will be marked destroyed anyway. That is the intention of the flag.

ok @DaanHoogland can you copy the description in StopVMCmd.java to other java classes ?

Yes, I have searched for the forced flag and alligned four classes here. Which others did I miss?

[weizhouapache]

as far as I know, the vm will be destroyed (force-stopped) on the kvm host as well. not sure how it works on vmware/xenserver.

It will be tried, but if it fails it will be marked destroyed anyway. That is the intention of the flag.

ok @DaanHoogland can you copy the description in StopVMCmd.java to other java classes ?

Yes, I have searched for the forced flag and alligned four classes here. Which others did I miss?

@DaanHoogland no more classes I think.
can you add (vm is marked as Stopped even when command fails to be send to the backend, otherwise a force poweroff is attempted). to the descriptions ?

[DaanHoogland]

gha should be enough @weizhouapache ?

[weizhouapache]

code lgtm

[weizhouapache]

gha should be enough @weizhouapache ?

yes @DaanHoogland

[codecov]

Codecov Report

Merging #7866 (1c2178d) into 4.18 (a47a4f4) will decrease coverage by 0.01%.
Report is 2 commits behind head on 4.18.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.18    #7866      +/-   ##
============================================
- Coverage     13.02%   13.02%   -0.01%     
+ Complexity     9040     9039       -1     
============================================
  Files          2720     2720              
  Lines        257094   257094              
  Branches      40092    40092              
============================================
- Hits          33491    33489       -2     
- Misses       219398   219401       +3     
+ Partials       4205     4204       -1     

Files Changed	Coverage Δ
...ava/com/cloud/api/commands/StopNetScalerVMCmd.java	0.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more