Skip to content

pre-commit fix line ending#7851

Merged
weizhouapache merged 1 commit into
apache:mainfrom
jbampton:pre-commit-fix-end-of-file
Aug 10, 2023
Merged

pre-commit fix line ending#7851
weizhouapache merged 1 commit into
apache:mainfrom
jbampton:pre-commit-fix-end-of-file

Conversation

@jbampton

Copy link
Copy Markdown
Member

Description

This PR fixes pre-commit when run on all files.

pre-commit run --all-files

Failing pre-commit run seen here:

https://github.com/apache/cloudstack/actions/runs/5824200820/job/15792706604

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@jbampton jbampton force-pushed the pre-commit-fix-end-of-file branch from b36fa59 to 765feab Compare August 10, 2023 18:01
@boring-cyborg boring-cyborg Bot added the Python Warning... Python code Ahead! label Aug 10, 2023

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache

weizhouapache commented Aug 10, 2023

Copy link
Copy Markdown
Member

no need for testing, merging
image

@weizhouapache weizhouapache merged commit 9bc0dd7 into apache:main Aug 10, 2023
@jbampton jbampton deleted the pre-commit-fix-end-of-file branch August 10, 2023 18:16
@DaanHoogland DaanHoogland added this to the 4.19.0.0 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:console-proxy Python Warning... Python code Ahead!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants