Skip to content

Remove powermock from kvm hypervisor plugin#7818

Merged
weizhouapache merged 5 commits into
apache:mainfrom
shapeblue:remove-powermock-kvm
Aug 10, 2023
Merged

Remove powermock from kvm hypervisor plugin#7818
weizhouapache merged 5 commits into
apache:mainfrom
shapeblue:remove-powermock-kvm

Conversation

@vishesh92

@vishesh92 vishesh92 commented Aug 5, 2023

Copy link
Copy Markdown
Member

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@vishesh92 vishesh92 force-pushed the remove-powermock-kvm branch from b108a00 to 8e1647b Compare August 5, 2023 17:17
@codecov

codecov Bot commented Aug 7, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7818 (afe3cc9) into main (32448e1) will increase coverage by 0.10%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7818      +/-   ##
============================================
+ Coverage     14.28%   14.38%   +0.10%     
- Complexity     9994    10075      +81     
============================================
  Files          2747     2747              
  Lines        258905   258911       +6     
  Branches      40318    40318              
============================================
+ Hits          36987    37252     +265     
+ Misses       217125   216844     -281     
- Partials       4793     4815      +22     

see 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6700

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6703

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

only src/test is changed, Trillian test is not required.

@weizhouapache weizhouapache merged commit 82f9106 into apache:main Aug 10, 2023
@DaanHoogland DaanHoogland deleted the remove-powermock-kvm branch August 10, 2023 07:09
@DaanHoogland DaanHoogland added this to the 4.19.0.0 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants