Remove GetUploadParamsForIsoCmd API duplicate parameters

[hsato03]

Description

The getUploadParamsForIso API has duplicate zoneId and name parameters, as the GetUploadParamsForIsoCmd class declares these two attributes and extends from AbstractGetUploadParamsCmd which already has these attributes. To address that the attributes declared in the GetUploadParamsForIsoCmd class were removed, keeping only the inherited attributes.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Called the getUploadParamsForIso API via Cloudmonkey passing no parameters. Before the changes, the "Missing required parameters" returned name and zoneId twice. After the changes, it returned once as expected.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

• In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
• Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
• Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
• Be sure to read the CloudStack Coding Conventions.
  Apache CloudStack is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
  Slack: https://apachecloudstack.slack.com/

[DaanHoogland]

clgtm

[harikrishna-patnala]

code LGTM

[codecov]

Codecov Report

Merging #7813 (172bd94) into main (7ee697f) will increase coverage by 0.00%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #7813   +/-   ##
=========================================
  Coverage     13.43%   13.43%           
  Complexity     9394     9394           
=========================================
  Files          2747     2747           
  Lines        258853   258853           
  Branches      40313    40313           
=========================================
+ Hits          34785    34786    +1     
+ Misses       219689   219685    -4     
- Partials       4379     4382    +3     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6689

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-7314)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48831 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7813-t7314-kvm-centos7.zip
Smoke tests completed. 110 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_trigger_shutdown	Failure	336.93	test_safe_shutdown.py
test_01_migrate_VM_and_root_volume	Error	84.86	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	58.50	test_vm_life_cycle.py
test_05_vmschedule_test_e2e	Failure	265.95	test_vm_schedule.py

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[weizhouapache]

code lgtm

[blueorangutan]

[SF] Trillian test result (tid-7351)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46594 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7813-t7351-kvm-centos7.zip
Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_upgrade_kubernetes_cluster	Failure	540.59	test_kubernetes_clusters.py
test_01_migrate_VM_and_root_volume	Error	81.83	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	59.52	test_vm_life_cycle.py

[GutoVeronezi]

CLGTM

[GutoVeronezi]

I checked the tests errors (#7813 (comment)) and they are not related to the PR.

I did some testing and the API is working fine:

/client/api/?bootable=true&isextractable=false&ispublic=false&zoneid=8b2ceb16-a2f2-40ea-8968-9e08984bdb17&name=a&displaytext=a&ostypeid=ec089cde-406d-11ee-a912-5254006051f5&format=ISO&command=getUploadParamsForIso&response=json


{
    "postuploadisoresponse": {
        "getuploadparams": {
            "id": "d7bb95e5-9883-4e05-9ecc-f549ca1dd4ec",
            "postURL": "https://172.16.200.100/upload/d7bb95e5-9883-4e05-9ecc-f549ca1dd4ec",
            "metadata": "QMfL9q9SHIYMZc2hT5bt0MhcE8JTG8RdD91h8vx2CSzjy+htQnQPcjxHq/rIDD/ubNfespFShnTTXH91A6KMV/v8QdDmX/5VUnfsDWFuMJ8XdAAdgmcfc1UAhlCHaj+ac0BWg2plIkikVVBgnu7wVd4NP3SzhW+xg8ehFPla/xgcKQZm29riWFD5tCjqIo1pTVf4tVz8p/wVVw0369iBZFht3rbD0KlvmoUMtwDs6O266NWEk9ECBsRwQ3r1qSTVlO9/Mvlm7Rlme22s7P23r5M5AH8ocjMhKzea5Coo+jEtxZd2dMuMbywD1HjLOYPLBv/tppeEpzlHj2WwDcAWKW7UvT8e+RRpits1VBzjtvjVvq2Y0KK9NCXfQC/d45uued5YGT3+QOY0TZ/Wux+mk6oFUWw8U4NLj+fw33h84jiXhDu4oRdcRC+KMb+77okkEYY2SehCqYQodRY6gqFWcDUvaVio4vKxWX+lmCt5QeovI03vf1WcmUKDXUME5YzYjlxiyzszjgC8P9TexPfCe+yaj0UbcqKzbtoeC4s/snQa+coIvtBbcXZ7hJ6FaPJS7WDeY5HUeo0LCldwjP9wN+JB4CocXAOdmIg5",
            "expires": "2023-08-31T22:04:18.496Z",
            "signature": "5yUAJjpB1cxBwEPv4B3JjnlFgzw="
        }
    }
}