Skip to content

pre-commit: standardize more line endings to lf#7804

Merged
DaanHoogland merged 1 commit into
apache:mainfrom
jbampton:line-endings
Oct 18, 2023
Merged

pre-commit: standardize more line endings to lf#7804
DaanHoogland merged 1 commit into
apache:mainfrom
jbampton:line-endings

Conversation

@jbampton

@jbampton jbampton commented Aug 2, 2023

Copy link
Copy Markdown
Member

https://github.com/pre-commit/pre-commit-hooks#mixed-line-ending

Description

This PR extends the "mixed line endings" pre-commit hook to apply to more file types.

Just trying to create a code standard to follow.

You can test locally from the repo root with:

pre-commit run --all-files

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@codecov

codecov Bot commented Aug 2, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7804 (c1c8bda) into main (6f45034) will increase coverage by 15.01%.
Report is 190 commits behind head on main.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #7804       +/-   ##
=============================================
+ Coverage     13.44%   28.45%   +15.01%     
- Complexity     9400    29631    +20231     
=============================================
  Files          2747     5102     +2355     
  Lines        258844   381661   +122817     
  Branches      40313    62409    +22096     
=============================================
+ Hits          34804   108606    +73802     
- Misses       219655   258242    +38587     
- Partials       4385    14813    +10428     
Flag Coverage Δ
simulator-marvin-tests 25.19% <ø> (?)
uitests 4.84% <ø> (?)
unit-tests 14.51% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3649 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jbampton

jbampton commented Aug 3, 2023

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@jbampton a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6632

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though a lot of the touched files seem unmaintained

@jbampton

jbampton commented Aug 3, 2023

Copy link
Copy Markdown
Member Author

lgtm, though a lot of the touched files seem unmaintained

We could also "exclude" files/folders from this check perhaps for this case of unmaintained files

@DaanHoogland

Copy link
Copy Markdown
Contributor

lgtm, though a lot of the touched files seem unmaintained

We could also "exclude" files/folders from this check perhaps for this case of unmaintained files

as long as it passes, never mind

@DaanHoogland DaanHoogland added this to the 4.19.0.0 milestone Sep 29, 2023
@shwstppr shwstppr closed this Oct 9, 2023
@shwstppr shwstppr reopened this Oct 9, 2023

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good. Lets run a round of smoke test as the number of files changed

@blueorangutan package

@shwstppr

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@shwstppr shwstppr removed their assignment Oct 17, 2023
@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7396

@shwstppr

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@shwstppr a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-7994)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44664 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7804-t7994-kvm-centos7.zip
Smoke tests completed. 111 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_trigger_shutdown Failure 337.08 test_safe_shutdown.py
test_03_deploy_vm_wrong_checksum Error 40.60 test_templates.py
test_09_list_templates_download_details Failure 0.04 test_templates.py

@DaanHoogland DaanHoogland merged commit 9834d51 into apache:main Oct 18, 2023
@jbampton jbampton deleted the line-endings branch September 17, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants