Skip to content

UI: fix creating zone with vxlan if Guest physical network is not the last#7801

Merged
yadvr merged 3 commits into
apache:4.18from
weizhouapache:4.18-ui-fix-create-zone-vxlan
Aug 22, 2023
Merged

UI: fix creating zone with vxlan if Guest physical network is not the last#7801
yadvr merged 3 commits into
apache:4.18from
weizhouapache:4.18-ui-fix-create-zone-vxlan

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR fixes #7790

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7801 (QA-JID-133)

@codecov

codecov Bot commented Aug 2, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7801 (78c71d1) into 4.18 (feb9509) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.18    #7801   +/-   ##
=========================================
  Coverage     13.02%   13.02%           
  Complexity     9032     9032           
=========================================
  Files          2720     2720           
  Lines        257080   257080           
  Branches      40088    40088           
=========================================
  Hits          33476    33476           
  Misses       219400   219400           
  Partials       4204     4204           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@weizhouapache weizhouapache marked this pull request as ready for review August 11, 2023 11:15
@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6750

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@yadvr yadvr added this to the 4.18.1.0 milestone Aug 11, 2023
@yadvr

yadvr commented Aug 11, 2023

Copy link
Copy Markdown
Member

Changes are strictly in the UI, both packaging/smoketests weren't necessary.
@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7801 (QA-JID-141)

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-7385)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46181 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7801-t7385-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_migrate_VM_and_root_volume Error 76.57 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 50.42 test_vm_life_cycle.py

@yadvr yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - didn't test it though

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7801 (QA-JID-144)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Guest physical networks with VXLAN doesn't accept VNI ranges > 4095 during zone creation

4 participants