Skip to content

Remove powermock from database/quota plugin#7795

Merged
DaanHoogland merged 1 commit into
apache:mainfrom
shapeblue:remove-powermock-from-db-quota
Aug 1, 2023
Merged

Remove powermock from database/quota plugin#7795
DaanHoogland merged 1 commit into
apache:mainfrom
shapeblue:remove-powermock-from-db-quota

Conversation

@vishesh92

@vishesh92 vishesh92 commented Jul 31, 2023

Copy link
Copy Markdown
Member

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@codecov

codecov Bot commented Jul 31, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7795 (697a916) into main (d51d8a4) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #7795   +/-   ##
=========================================
  Coverage     13.43%   13.44%           
- Complexity     9394     9396    +2     
=========================================
  Files          2747     2747           
  Lines        258844   258844           
  Branches      40313    40313           
=========================================
+ Hits          34780    34794   +14     
+ Misses       219682   219666   -16     
- Partials       4382     4384    +2     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6613

@harikrishna-patnala harikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland merged commit 0d9292c into apache:main Aug 1, 2023
@DaanHoogland DaanHoogland added this to the 4.19.0.0 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants