Remove powermock from network elements#7791
Merged
DaanHoogland merged 5 commits intoAug 7, 2023
Merged
Conversation
fdf7c86 to
656adc9
Compare
Codecov Report
@@ Coverage Diff @@
## main #7791 +/- ##
============================================
+ Coverage 13.43% 14.25% +0.81%
- Complexity 9392 9963 +571
============================================
Files 2747 2747
Lines 258827 258841 +14
Branches 40318 40311 -7
============================================
+ Hits 34774 36891 +2117
+ Misses 219671 217177 -2494
- Partials 4382 4773 +391 see 46 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
@blueorangutan package |
|
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6605 |
DaanHoogland
approved these changes
Jul 31, 2023
DaanHoogland
left a comment
Contributor
There was a problem hiding this comment.
I see no strange things in the (test) code and packaging works => let's merge
harikrishna-patnala
approved these changes
Jul 31, 2023
harikrishna-patnala
left a comment
Member
There was a problem hiding this comment.
PR increases coverage by 0.81%.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes powermock from network-elements (
tungsten&elastic-loadbalancer).After this PR, powermock usage is as follows:
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?