Skip to content

Remove powermock from network elements#7791

Merged
DaanHoogland merged 5 commits into
apache:mainfrom
shapeblue:remove-powermock-from-network-elements
Aug 7, 2023
Merged

Remove powermock from network elements#7791
DaanHoogland merged 5 commits into
apache:mainfrom
shapeblue:remove-powermock-from-network-elements

Conversation

@vishesh92

Copy link
Copy Markdown
Member

Description

This PR removes powermock from network-elements (tungsten & elastic-loadbalancer).

After this PR, powermock usage is as follows:

git grep -i "PowerMockito" | tr "/" " "| awk '{print $1, $2, $3}' | sort | uniq -c  
     76 api src test
     51 core src test
     37 engine schema src
     68 engine storage configdrive
      9 engine storage snapshot
      3 plugins database quota
    150 plugins hypervisors kvm
      3 plugins hypervisors vmware
     40 plugins hypervisors xenserver
    202 server src test
      4 services console-proxy server
      2 services secondary-storage server
      7 vmware-base src test

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@vishesh92 vishesh92 force-pushed the remove-powermock-from-network-elements branch from fdf7c86 to 656adc9 Compare July 29, 2023 17:45
@vishesh92 vishesh92 requested a review from DaanHoogland July 29, 2023 17:47
@vishesh92 vishesh92 marked this pull request as draft July 29, 2023 18:10
@codecov

codecov Bot commented Jul 30, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7791 (be4fd17) into main (a738204) will increase coverage by 0.81%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7791      +/-   ##
============================================
+ Coverage     13.43%   14.25%   +0.81%     
- Complexity     9392     9963     +571     
============================================
  Files          2747     2747              
  Lines        258827   258841      +14     
  Branches      40318    40311       -7     
============================================
+ Hits          34774    36891    +2117     
+ Misses       219671   217177    -2494     
- Partials       4382     4773     +391     

see 46 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6605

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no strange things in the (test) code and packaging works => let's merge

@harikrishna-patnala harikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR increases coverage by 0.81%.

LGTM

@vishesh92 vishesh92 marked this pull request as ready for review July 31, 2023 15:02
@harikrishna-patnala harikrishna-patnala added this to the 4.19.0.0 milestone Aug 1, 2023
@DaanHoogland DaanHoogland merged commit 55f0801 into apache:main Aug 7, 2023
@DaanHoogland DaanHoogland deleted the remove-powermock-from-network-elements branch August 7, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants