Skip to content

Remove powermock from nicira nvp#7789

Merged
DaanHoogland merged 1 commit into
apache:mainfrom
shapeblue:remove-powermock-nicira-nvp
Jul 28, 2023
Merged

Remove powermock from nicira nvp#7789
DaanHoogland merged 1 commit into
apache:mainfrom
shapeblue:remove-powermock-nicira-nvp

Conversation

@vishesh92

Copy link
Copy Markdown
Member

Description

This PR removes powermock from nicira nvp plugin's tests

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, but this code is not maintained atm, so maybe not spend the effort (too late ;)

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Jul 28, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7789 (f34e301) into main (8db8aa4) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #7789   +/-   ##
=========================================
  Coverage     13.42%   13.43%           
- Complexity     9383     9390    +7     
=========================================
  Files          2747     2747           
  Lines        258827   258827           
  Branches      40318    40318           
=========================================
+ Hits          34748    34772   +24     
+ Misses       219694   219673   -21     
+ Partials       4385     4382    -3     
Files Changed Coverage Δ
...ava/com/cloud/network/nicira/NiciraRestClient.java 82.66% <ø> (+31.99%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6595

@DaanHoogland DaanHoogland merged commit a738204 into apache:main Jul 28, 2023
@DaanHoogland DaanHoogland deleted the remove-powermock-nicira-nvp branch July 28, 2023 11:24
@DaanHoogland DaanHoogland added this to the 4.19.0.0 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants