api: userdata api access for non-rootadmins

[shwstppr]

Description

Fixes userdata API access for domain admins, normal user.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[DaanHoogland]

clgtm

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5690

[DaanHoogland]

@blueorangutan test matrix

[blueorangutan]

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-6270)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38581 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7319-t6270-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[blueorangutan]

Trillian test result (tid-6268)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41035 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7319-t6268-xenserver-71.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_cancel_host_maintenace_with_migration_jobs	Error	1512.76	test_host_maintenance.py

[blueorangutan]

Trillian test result (tid-6269)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 42115 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7319-t6269-vmware-67u3.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[yadvr]

LGTM

[vladimirpetrov]

LGTM based on manual testing. Tested scenarios:

as user:

L2 network CD, jinja script for create file - OK
L2 network CD, manual text override - OK
Shared VR - simple text - OK
Shared VR - overridden text - OK
L2 network CD, overridden with jinja script for file create - OK
Shared network VR, overridden with jinja script for file create - OK
Isolated network CD, overridden with jinja script for file create - OK
as domain admin:

Shared VR, simple text - OK
Shared VR, overridden text - OK
L2 network CD, simple text - OK
L2 network CD, overridden text - OK
L2 network CD, overridden with jinja script for file create - OK
Shared network VR, overridden with jinja script for file create - OK

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication