Skip to content

UI: fix error message when create load balancer as a normal user#7286

Merged
DaanHoogland merged 1 commit into
apache:mainfrom
weizhouapache:4.18-ui-fix-error-create-lb-as-user
Feb 24, 2023
Merged

UI: fix error message when create load balancer as a normal user#7286
DaanHoogland merged 1 commit into
apache:mainfrom
weizhouapache:4.18-ui-fix-error-create-lb-as-user

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This fixes an error message when create load balancer as a normal user

image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, not sure how to test though

@weizhouapache

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5637

@codecov

codecov Bot commented Feb 23, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7286 (25bf8cc) into main (aa881f6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #7286   +/-   ##
=========================================
  Coverage     12.69%   12.69%           
  Complexity     8655     8655           
=========================================
  Files          2716     2716           
  Lines        256117   256117           
  Branches      39927    39927           
=========================================
  Hits          32503    32503           
  Misses       219482   219482           
  Partials       4132     4132           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DaanHoogland DaanHoogland added this to the 4.18.0.0 milestone Feb 24, 2023
@yadvr

yadvr commented Feb 24, 2023

Copy link
Copy Markdown
Member

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7286 (QA-JID-53)

@DaanHoogland

Copy link
Copy Markdown
Contributor

@msinhore does this test ok for you?

@msinhore

Copy link
Copy Markdown

@msinhore does this test ok for you?

Yes, it is working as expected now. Thank you @weizhouapache @DaanHoogland

@DaanHoogland DaanHoogland merged commit c4b444d into apache:main Feb 24, 2023
@weizhouapache weizhouapache deleted the 4.18-ui-fix-error-create-lb-as-user branch February 24, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants