avoid hard coded guest OS IDs

[DaanHoogland]

Description

This PR tries to avoid problems with guest os hypervisor mapping that we see in some DBs. If site specific entries were added the mapping may break on this.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[weizhouapache]

makes sense

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5630

[codecov]

Codecov Report

Merging #7279 (6ab852f) into main (a367049) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 6ab852f differs from pull request most recent head 0a13424. Consider uploading reports for the commit 0a13424 to get more accurate results

@@             Coverage Diff              @@
##               main    #7279      +/-   ##
============================================
- Coverage     12.69%   12.69%   -0.01%     
  Complexity     8655     8655              
============================================
  Files          2716     2716              
  Lines        256112   256117       +5     
  Branches      39926    39927       +1     
============================================
  Hits          32503    32503              
- Misses       219477   219482       +5     
  Partials       4132     4132              

Impacted Files	Coverage Δ
...src/main/java/com/cloud/upgrade/GuestOsMapper.java	5.10% <0.00%> (-0.28%)	⬇️
...ava/com/cloud/upgrade/dao/Upgrade41720to41800.java	0.85% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5631

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
28.6% Duplication

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5634

[borisstoyanov]

@blueorangutan test

[blueorangutan]

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[borisstoyanov]

LGTM, manually tested the changes

[weizhouapache]

code lgtm

makes perfect sense to remove hard-coded guest os id.

The last time we use hard-coded guest os id is in the upgrade to 4.13.0. If an environment was created after 4.13.0, it will be upgraded to latest 4.18 successfully, no mater if there are custom guest oses or mappings.

[blueorangutan]

Trillian test result (tid-6220)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40951 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7279-t6220-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_ping_in_ssvm_success	Error	1.09	test_diagnostics.py
test_04_ping_in_ssvm_failure	Error	1.10	test_diagnostics.py
test_05_ping_in_cpvm_success	Error	1.10	test_diagnostics.py
test_06_ping_in_cpvm_failure	Error	1.08	test_diagnostics.py
test_08_arping_in_ssvm	Error	1.09	test_diagnostics.py
test_09_arping_in_cpvm	Error	1.09	test_diagnostics.py
test_11_traceroute_in_ssvm	Error	1.08	test_diagnostics.py
test_12_traceroute_in_cpvm	Error	1.09	test_diagnostics.py
test_15_retrieve_ssvm_default_files	Error	1.09	test_diagnostics.py
test_16_retrieve_ssvm_single_file	Error	1.09	test_diagnostics.py
test_17_retrieve_cpvm_default_files	Error	1.09	test_diagnostics.py
test_18_retrieve_cpvm_single_file	Error	1.10	test_diagnostics.py