Fix select default host option on deployment wizard

[nvazquez]

Description

This PR fixes the Default option for Pod, Cluster and Hosts on the VM deployment wizard

Fixes: #7204

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Deploy Instance wizard, select a host, then click Default. Same with Pod and Cluster

[nvazquez]

@blueorangutan ui

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7256 (QA-JID-49)

[DaanHoogland]

clgtm

[harikrishna-patnala]

I've tried to test it @nvazquez but it shows the default option only on selecting it second time

1. Selected a host
   
2. Selected the default option, it still shows empty
   
3. Selected the default option again, then able to see the default option
   

[nvazquez]

@harikrishna-patnala yes, before the fix it was not possible to unselect a host, I think it is correct the field gets empty if Default is selected

[codecov]

Codecov Report

Merging #7256 (4b634eb) into 4.17 (e62062f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.17    #7256   +/-   ##
=========================================
  Coverage     10.38%   10.38%           
- Complexity     6650     6652    +2     
=========================================
  Files          2453     2453           
  Lines        242444   242444           
  Branches      37941    37941           
=========================================
+ Hits          25171    25175    +4     
+ Misses       214155   214151    -4     
  Partials       3118     3118           

Impacted Files	Coverage Δ
...apache/cloudstack/syslog/AlertsSyslogAppender.java	58.75% <0.00%> (+2.25%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[harikrishna-patnala]

@harikrishna-patnala yes, before the fix it was not possible to unselect a host, I think it is correct the field gets empty if Default is selected

at first attempt it looked like even after selecting "default", empty option is displayed instead of "default". Functionally both are same but I felt when selecting "default" it should show "default".

But the initial problem is solved, so LGTM

[kiranchavala]

@blueorangutan package

[blueorangutan]

@kiranchavala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5610