Skip to content

UI: Fix keyboard options regression#7230

Merged
DaanHoogland merged 3 commits into
apache:mainfrom
shapeblue:fix-keyboard-i18-text
Feb 20, 2023
Merged

UI: Fix keyboard options regression#7230
DaanHoogland merged 3 commits into
apache:mainfrom
shapeblue:fix-keyboard-i18-text

Conversation

@nvazquez

@nvazquez nvazquez commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

Description

This PR fixes a UI regression on the keyboard options on the Deploy Instance wizard (restored labels form the PR #6326 in which they were removed):

image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Deploy Instance wizard -> Verify new text options for keyboard

@nvazquez

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7230 (QA-JID-46)

@codecov

codecov Bot commented Feb 15, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7230 (cd4737d) into main (597a803) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #7230   +/-   ##
=========================================
  Coverage     12.67%   12.67%           
  Complexity     8639     8639           
=========================================
  Files          2716     2716           
  Lines        256112   256112           
  Branches      39926    39926           
=========================================
  Hits          32456    32456           
  Misses       219528   219528           
  Partials       4128     4128           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@harikrishna-patnala

Copy link
Copy Markdown
Member

verified LGTM

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@shwstppr

Copy link
Copy Markdown
Contributor

Verified on QA server

Screenshot from 2023-02-15 13-16-01

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified OK

there is no translation for "French AZERTY keyboard" when language changes

@DaanHoogland DaanHoogland added this to the 4.18.0.0 milestone Feb 15, 2023
@DaanHoogland DaanHoogland mentioned this pull request Feb 15, 2023
12 tasks
Comment thread ui/public/locales/nl_NL.json
Comment thread ui/public/locales/nl_NL.json
Comment thread ui/public/locales/pt_BR.json Outdated
Comment thread ui/public/locales/pt_BR.json Outdated
Comment thread ui/public/locales/pt_BR.json Outdated
Comment thread ui/public/locales/pt_BR.json Outdated
@weizhouapache

Copy link
Copy Markdown
Member

This is not the first issue , maybe also not the last issue caused by #6326

Co-authored-by: Stephan Krug <stekrug@icloud.com>
@nvazquez

Copy link
Copy Markdown
Contributor Author

Thanks @stephankruggg I've applied your suggestions for portuguese
@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7230 (QA-JID-48)

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DaanHoogland DaanHoogland merged commit 3d2fffc into apache:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants