SQL: Remove snapshot references if primary storage pool has been removed

[weizhouapache]

Description

This PR fixes #7093

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codecov]

Codecov Report

Merging #7205 (18a3682) into main (f2d1a34) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #7205   +/-   ##
=========================================
  Coverage     12.67%   12.67%           
- Complexity     8637     8641    +4     
=========================================
  Files          2716     2716           
  Lines        256112   256112           
  Branches      39926    39926           
=========================================
+ Hits          32452    32461    +9     
+ Misses       219533   219522   -11     
- Partials       4127     4129    +2     

Impacted Files	Coverage Δ
...dstack/network/contrail/model/ModelObjectBase.java	28.84% <0.00%> (+7.69%)	⬆️
...com/cloud/agent/manager/ConnectedAgentAttache.java	37.50% <0.00%> (+12.50%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[DaanHoogland]

@weizhouapache is this an upgrade only action? It seems by the description, it should be done in a clean-up task that runs regularly.

[weizhouapache]

@weizhouapache is this an upgrade only action? It seems by the description, it should be done in a clean-up task that runs regularly.

@DaanHoogland
I think the original issue has been fixed. Users just need to run the SQL once.

[yadvr]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5609

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-6202)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 53840 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7205-t6202-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_upgrade_kubernetes_cluster	Error	3965.55	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Error	4034.13	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	117.44	test_kubernetes_clusters.py

[vladimirpetrov]

LGTM based on manual testing, reproduced on 4.15.2, upgraded to 4.17.2, then to this PR and the problem disappeared. Tested with VMWare 6.7u3.