Skip to content

UI: fix 'Next' button is stuck if no public ip range#7198

Merged
DaanHoogland merged 2 commits into
apache:mainfrom
weizhouapache:4.18-ui-fix-empty-public-iprange
Feb 13, 2023
Merged

UI: fix 'Next' button is stuck if no public ip range#7198
DaanHoogland merged 2 commits into
apache:mainfrom
weizhouapache:4.18-ui-fix-empty-public-iprange

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR fixes #7195

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vladimirpetrov

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@vladimirpetrov a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Feb 13, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7198 (4030685) into main (e61ab3d) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7198      +/-   ##
============================================
+ Coverage     12.63%   12.67%   +0.03%     
- Complexity     8613     8639      +26     
============================================
  Files          2711     2716       +5     
  Lines        255753   256112     +359     
  Branches      39874    39926      +52     
============================================
+ Hits          32325    32456     +131     
- Misses       219321   219528     +207     
- Partials       4107     4128      +21     
Impacted Files Coverage Δ
...ma/src/main/java/com/cloud/user/UserAccountVO.java 46.31% <0.00%> (-4.94%) ⬇️
...ne/schema/src/main/java/com/cloud/user/UserVO.java 42.85% <0.00%> (-4.02%) ⬇️
...om/cloud/api/query/dao/UserAccountJoinDaoImpl.java 20.00% <0.00%> (-1.74%) ⬇️
...java/com/cloud/api/query/vo/UserAccountJoinVO.java 27.08% <0.00%> (-0.58%) ⬇️
...loud/hypervisor/kvm/resource/VRouterVifDriver.java 5.40% <0.00%> (-0.16%) ⬇️
...ain/java/org/apache/cloudstack/saml/SAMLUtils.java 64.80% <0.00%> (-0.14%) ⬇️
server/src/main/java/com/cloud/api/ApiServer.java 1.83% <0.00%> (-0.05%) ⬇️
...in/java/com/cloud/server/ManagementServerImpl.java 5.65% <0.00%> (-0.01%) ⬇️
...java/com/cloud/agent/manager/AgentManagerImpl.java 4.94% <0.00%> (-0.01%) ⬇️
...r/src/main/java/com/cloud/user/AccountManager.java 100.00% <0.00%> (ø)
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5569

@vladimirpetrov vladimirpetrov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on manual testing.

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland merged commit 933970d into apache:main Feb 13, 2023
@DaanHoogland DaanHoogland deleted the 4.18-ui-fix-empty-public-iprange branch February 13, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Add zone' dialog stuck on step 4 if no network is added

4 participants