UI: fix 'Next' button is stuck if no public ip range#7198
Merged
DaanHoogland merged 2 commits intoFeb 13, 2023
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
|
@blueorangutan package |
|
@vladimirpetrov a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report
@@ Coverage Diff @@
## main #7198 +/- ##
============================================
+ Coverage 12.63% 12.67% +0.03%
- Complexity 8613 8639 +26
============================================
Files 2711 2716 +5
Lines 255753 256112 +359
Branches 39874 39926 +52
============================================
+ Hits 32325 32456 +131
- Misses 219321 219528 +207
- Partials 4107 4128 +21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5569 |
vladimirpetrov
approved these changes
Feb 13, 2023
vladimirpetrov
left a comment
Contributor
There was a problem hiding this comment.
LGTM based on manual testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This PR fixes #7195
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?