Allow specifying disk size, min/max iops for offering linked with custom disk offering by Pearl1594 · Pull Request #6018 · apache/cloudstack

Pearl1594 · 2022-02-21T13:56:40Z

Description

This PR fixes the issue noticed when trying to scale a VM to an offering with custom disk offering.
UI doesn't provide an option to pass the disk size & iops values

Post Fix:

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

…tom disk offering

sureshanaparti

code LGTM

Pearl1594 · 2022-02-22T09:41:57Z

@blueorangutan package

blueorangutan · 2022-02-22T09:43:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-22T10:38:37Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2681

sureshanaparti · 2022-02-22T11:26:36Z

@blueorangutan test

blueorangutan · 2022-02-22T11:27:02Z

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-02-23T19:30:10Z

Trillian test result (tid-3409)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 114070 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6018-t3409-kvm-centos7.zip
Smoke tests completed. 59 look OK, 33 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestDeployVMFromISO>:setup	`Error`	0.00	test_deploy_vm_iso.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
test_01_create_template	`Error`	20.54	test_templates.py
test_CreateTemplateWithDuplicateName	`Error`	27.74	test_templates.py
test_02_create_template_with_checksum_sha1	`Error`	65.37	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	65.39	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	65.50	test_templates.py
test_05_create_template_with_no_checksum	`Error`	65.40	test_templates.py
test_03_delete_template	`Error`	1.06	test_templates.py
test_04_extract_template	`Error`	1.07	test_templates.py
test_09_list_templates_download_details	`Failure`	0.05	test_templates.py
ContextSuite context=TestRemoteDiagnostics>:setup	`Error`	0.00	test_diagnostics.py
ContextSuite context=TestLoadBalance>:setup	`Error`	0.00	test_loadbalance.py
test_06_download_detached_volume	`Error`	299.74	test_volumes.py
ContextSuite context=TestVolumes>:teardown	`Error`	122.93	test_volumes.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup	`Error`	0.00	test_deploy_virtio_scsi_vm.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup	`Error`	0.00	test_password_server.py
test_01_add_primary_storage_disabled_host	`Error`	0.55	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.10	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.18	test_primary_storage.py
ContextSuite context=TestDeployVmWithUserData>:setup	`Error`	0.00	test_deploy_vm_with_userdata.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup	`Error`	0.00	test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup	`Error`	0.00	test_resource_accounting.py
ContextSuite context=TestPortForwardingRules>:setup	`Error`	0.00	test_portforwardingrules.py
ContextSuite context=TestPrivateGwACL>:setup	`Error`	0.00	test_privategw_acl.py
ContextSuite context=TestDomainsServiceOfferings>:setup	`Error`	1514.82	test_domain_service_offerings.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
test_01_template_usage	`Error`	19.59	test_usage.py
test_01_volume_usage	`Error`	185.98	test_usage.py
test_list_clusters_metrics	`Error`	1512.31	test_metrics_api.py
test_list_vms_metrics	`Error`	0.16	test_metrics_api.py
ContextSuite context=TestVPCRedundancy>:setup	`Error`	0.00	test_vpc_redundant.py
test_02_list_snapshots_with_removed_data_store	`Error`	8.53	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	8.53	test_snapshots.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestIsolatedNetworks>:setup	`Error`	0.00	test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup	`Error`	0.00	test_routers_network_ops.py
ContextSuite context=TestInternalLb>:setup	`Error`	0.00	test_internal_lb.py
test_01_create_iso_with_checksum_sha1	`Error`	66.44	test_iso.py
test_02_create_iso_with_checksum_sha256	`Error`	66.42	test_iso.py
test_03_create_iso_with_checksum_md5	`Error`	66.66	test_iso.py
test_04_create_iso_with_no_checksum	`Error`	66.39	test_iso.py
test_01_create_iso	`Failure`	1513.49	test_iso.py
ContextSuite context=TestISO>:setup	`Error`	3026.16	test_iso.py
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	0.01	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.01	test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version	`Error`	1802.12	test_kubernetes_supported_versions.py
ContextSuite context=TestListIdsParams>:setup	`Error`	0.00	test_list_ids_parameter.py
test_delete_account	`Error`	1512.26	test_network.py
test_delete_network_while_vm_on_it	`Error`	1.12	test_network.py
test_deploy_vm_l2network	`Error`	1.12	test_network.py
test_l2network_restart	`Error`	2.23	test_network.py
ContextSuite context=TestPortForwarding>:setup	`Error`	3.39	test_network.py
ContextSuite context=TestPublicIP>:setup	`Error`	3.56	test_network.py
test_reboot_router	`Failure`	0.05	test_network.py
test_releaseIP	`Error`	1.68	test_network.py
ContextSuite context=TestRouterRules>:setup	`Error`	1.73	test_network.py
test_01_secure_vm_migration	`Error`	150.35	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	268.86	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	141.85	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	43.74	test_vm_life_cycle.py
test_hostha_kvm_host_degraded	`Error`	693.45	test_hostha_kvm.py
test_hostha_kvm_host_fencing	`Error`	676.77	test_hostha_kvm.py
test_hostha_kvm_host_recovering	`Error`	699.30	test_hostha_kvm.py

DaanHoogland

clgtm

Pearl1594 · 2022-03-02T06:55:34Z

@blueorangutan package

blueorangutan · 2022-03-02T06:56:02Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-03-02T07:56:29Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2741

Pearl1594 · 2022-03-02T11:38:08Z

@blueorangutan test

blueorangutan · 2022-03-02T11:39:03Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-03-02T22:16:49Z

Trillian test result (tid-3459)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36889 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6018-t3459-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

nvazquez

LGTM

Allow specifying disk size, min/max iops for offering linked with cus…

2a7ac30

…tom disk offering

Pearl1594 requested a review from harikrishna-patnala February 21, 2022 13:58

Pearl1594 added this to the 4.17.0.0 milestone Feb 21, 2022

Pearl1594 requested a review from sureshanaparti February 22, 2022 05:06

sureshanaparti approved these changes Feb 22, 2022

View reviewed changes

Pearl1594 marked this pull request as ready for review February 22, 2022 09:41

DaanHoogland approved these changes Feb 25, 2022

View reviewed changes

harikrishna-patnala approved these changes Mar 2, 2022

View reviewed changes

Pearl1594 added the status:needs-testing label Mar 2, 2022

nvazquez added type:bug and removed status:needs-testing labels Mar 5, 2022

nvazquez approved these changes Mar 5, 2022

View reviewed changes

nvazquez merged commit 4d54e8e into apache:main Mar 5, 2022

Uh oh!

Conversation

Pearl1594 commented Feb 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

Pearl1594 commented Feb 22, 2022

Uh oh!

blueorangutan commented Feb 22, 2022

Uh oh!

blueorangutan commented Feb 22, 2022

Uh oh!

sureshanaparti commented Feb 22, 2022

Uh oh!

blueorangutan commented Feb 22, 2022

Uh oh!

blueorangutan commented Feb 23, 2022

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Pearl1594 commented Mar 2, 2022

Uh oh!

blueorangutan commented Mar 2, 2022

Uh oh!

blueorangutan commented Mar 2, 2022

Uh oh!

Pearl1594 commented Mar 2, 2022

Uh oh!

blueorangutan commented Mar 2, 2022

Uh oh!

blueorangutan commented Mar 2, 2022

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Pearl1594 commented Feb 21, 2022 •

edited

Loading