Skip to content

UI: fix network list when assign vm to other accounts in project view#6009

Merged
nvazquez merged 2 commits into
apache:mainfrom
weizhouapache:4.17-fix-networks-list-assignvm-in-project-view
Feb 21, 2022
Merged

UI: fix network list when assign vm to other accounts in project view#6009
nvazquez merged 2 commits into
apache:mainfrom
weizhouapache:4.17-fix-networks-list-assignvm-in-project-view

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR fixes the issue that the network list when assign vm to other accounts in project view
the issue is found when tested the feature for #5248

new UI

image

old /wrong UI

image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache weizhouapache marked this pull request as ready for review February 18, 2022 13:38
@weizhouapache weizhouapache added this to the 4.17.0.0 milestone Feb 18, 2022
@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6009 (SL-JID-1150)

@nvazquez nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvazquez nvazquez merged commit b8ce074 into apache:main Feb 21, 2022
@weizhouapache weizhouapache deleted the 4.17-fix-networks-list-assignvm-in-project-view branch December 9, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants