Skip to content

ui: Adding option to select columns to display#6001

Merged
nvazquez merged 1 commit into
apache:mainfrom
shapeblue:select-columns
Feb 21, 2022
Merged

ui: Adding option to select columns to display#6001
nvazquez merged 1 commit into
apache:mainfrom
shapeblue:select-columns

Conversation

@davidjumani

Copy link
Copy Markdown
Contributor

Description

Fixes #5555
Allows users to customize columns to display in the listView

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

Screenshot from 2022-02-17 13-08-39

@davidjumani davidjumani requested a review from utchoang February 17, 2022 07:40
@davidjumani davidjumani added this to the 4.17.0.0 milestone Feb 17, 2022
@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6001 (SL-JID-1144)

@utchoang utchoang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidjumani I think the dropdown should be displayed when the user clicks on it instead of hovering over it. In addition, it is possible to allow multiple selections once instead of having to select each item (now each selection will turn off the dropdown).

@davidjumani davidjumani force-pushed the select-columns branch 2 times, most recently from 05b4925 to e44adca Compare February 21, 2022 08:08
@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6001 (SL-JID-1161)

@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6001 (SL-JID-1162)

@utchoang utchoang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nvazquez nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - manually tested OK

@nvazquez nvazquez merged commit b9e973a into apache:main Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Hide the 'Power State' column on host tables when Host HA is not enabled - UI

5 participants