Skip to content

ui: Pass rootdisksize only if template is not deployasis#5995

Merged
nvazquez merged 1 commit into
apache:mainfrom
shapeblue:fix-deployvm-rootdisk
Feb 15, 2022
Merged

ui: Pass rootdisksize only if template is not deployasis#5995
nvazquez merged 1 commit into
apache:mainfrom
shapeblue:fix-deployvm-rootdisk

Conversation

@davidjumani

Copy link
Copy Markdown
Contributor

Description

Fixes the issue of not being able to deploy a VM from a deploy-as-is template
Screen Shot 2022-02-15 at 00 09 32

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

@davidjumani davidjumani requested a review from utchoang February 15, 2022 04:14
@davidjumani davidjumani added this to the 4.17.0.0 milestone Feb 15, 2022
@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5995 (SL-JID-1134)

@utchoang utchoang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nvazquez nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - manually tested

@nvazquez nvazquez merged commit b1bb22d into apache:main Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants