Skip to content

UI: Filter menu UX improvements#5994

Merged
nvazquez merged 4 commits into
apache:mainfrom
EWERK-DIGITAL:feature/fix-select-option-filter-menu
Feb 18, 2022
Merged

UI: Filter menu UX improvements#5994
nvazquez merged 4 commits into
apache:mainfrom
EWERK-DIGITAL:feature/fix-select-option-filter-menu

Conversation

@utchoang

Copy link
Copy Markdown

Description

This PR fixes #5926

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

  • Show full content option
    image
  • Sort by alphabest
    image

How Has This Been Tested?

@utchoang

Copy link
Copy Markdown
Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5994 (SL-JID-1131)

@davidjumani

Copy link
Copy Markdown
Contributor

@utchoang Can you modify line 86 to {{ $t(opt.path || opt.name) }} to display the full domain path. Otherwise great job! :)

@sureshanaparti sureshanaparti added this to the 4.17.0.0 milestone Feb 15, 2022
@sureshanaparti sureshanaparti linked an issue Feb 15, 2022 that may be closed by this pull request
@utchoang

Copy link
Copy Markdown
Author

@blueorangutan ui

1 similar comment
@davidjumani

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5994 (SL-JID-1135)

Comment thread ui/src/components/view/SearchView.vue Outdated
@davidjumani

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5994 (SL-JID-1136)

Comment thread ui/src/components/view/SearchView.vue Outdated
@davidjumani

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5994 (SL-JID-1139)

@davidjumani davidjumani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @utchoang

@sureshanaparti

Copy link
Copy Markdown
Contributor

Verified the filter drop down. LGTM.

@davidjumani davidjumani changed the base branch from 4.16 to main February 16, 2022 04:40
@davidjumani

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5994 (SL-JID-1140)

@nvazquez nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nvazquez nvazquez merged commit 9eefc76 into apache:main Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

UI: Filter menu UX improvements

5 participants