Fix attach volume error for VM - different scope for VM volume and volume disk offering

[nvazquez]

Description

This PR fixes an issue attaching a volume to a VM with volume on zone-wide storage pool, for target cluster-wide storage according the disk offering

Fixes: #5916

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2573

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2574

[nvazquez]

Tested on simulator (with the use of PR #5986 to allow zone-wide storage):

Cluster 1: NFS store 1 and 2 cluster-wide stores
Cluster 2: NFS store 3 and 4 cluster-wide stores
Zone wide: NFS store 5
Disk offering: storage tag A
VM deployed cluster 1, ROOT disk on zone-wide storage 5

Case 1:

• Set NFS store 1 storage tag = A
• Create a disk with offering A
• Attach to VM -> SUCCESS

Case 2:

• Remove storage tag from NFS store 1 and set NFS store 3 tag = A
• Create a disk with offering A
• Attach to VM -> FAILURE (as the target cluster is different from the VM cluster)

@DaanHoogland @slavkap the failure on case 2 can be solved if prior to the disk attach, the VM is migrated to a host in the same cluster as the store with has the storage tag of the disk. Do you think this case should be fixed by the code as well or handled as an operational issue?

[DaanHoogland]

@nvazquez I think we can offer in the UI but the API is clear cut and doesn't need this extra action. This is a scripting issue to me, and the UI could do that or terraform or some other automation framework. But the backend should not do this automatically.
€0,02

[slavkap]

LGTM manually tested, and only the 1st case works

[nvazquez]

Thanks @DaanHoogland @slavkap!
@blueorangutan test matrix

[blueorangutan]

@nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-3303)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32184 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5982-t3303-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[blueorangutan]

Trillian test result (tid-3302)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36458 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5982-t3302-xenserver-71.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[blueorangutan]

Trillian test result (tid-3304)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37332 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5982-t3304-vmware-65u2.zip
Smoke tests completed. 90 look OK, 2 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_offline_migrate_VM_and_root_volume	Error	90.86	test_vm_life_cycle.py
test_03_live_migrate_VM_with_two_data_disks	Error	59.50	test_vm_life_cycle.py
test_06_disk_offering_strictness_false	Error	149.65	test_service_offerings.py