[Draft] VR: remove old json config when start vmware/xenserver VPC VRs

[weizhouapache]

Description

This PR fixes the issue that the IPs are associated to wrong interfaces when reboot a VR on vmware/xen environment.
However, VR will be broken if it is rebooted in vCenter or XenCenter (not in cloudstack).

steps to reproduce the issue
(1) create vpc, and a vpc tier
(2) acquire an ip in additional ip range, enable static nat or pf/lb
(3) stop VR in cloudstack, start it in vCenter; OR restart VR in vCenter

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2465

[nvazquez]

@sureshanaparti should this be considered on 4.16.1?

[weizhouapache]

@blueorangutan test centos7 xcpng82

[blueorangutan]

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + xcpng82) has been kicked to run smoke tests

[yadvr]

@weizhouapache doesn't this beat the whole idea of persistent configs in VRs? cc @sureshanaparti @DaanHoogland

[weizhouapache]

@weizhouapache doesn't this beat the whole idea of persistent configs in VRs? cc @sureshanaparti @DaanHoogland

@rohityadavcloud

each time when VR is started from cloudstack, the config files are regenerated. so it is not required in this scenario.
I understand persistent config is helpful when reboot VR in vcenter or xencenter.
However, it breaks VPC VR when reboot it in cloudstack in many scenarios.

ps: this behaviour has been aplied for vpc vrs on kvm hosts, where there is no centrailized management other than cloudstack.

[DaanHoogland]

@blueorangutan test centos7 vmware-7u2

[blueorangutan]

@DaanHoogland unsupported parameters provided. Supported mgmt server os are: suse15, centos7, centos6, alma8, ubuntu18, ubuntu20, rocky8. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-ubuntu18, kvm-ubuntu20, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82

[DaanHoogland]

@blueorangutan test centos7 vmware-70u2

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-70u2) has been kicked to run smoke tests

[weizhouapache]

@weizhouapache can you reply on @GutoVeronezi ś comments?

@DaanHoogland
moved this to draft.

[blueorangutan]

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 4878

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5476

[DaanHoogland]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[DaanHoogland]

@blueorangutan test centos7 xcpng-82

[blueorangutan]

@DaanHoogland unsupported parameters provided. Supported mgmt server os are: centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82

[weizhouapache]

@DaanHoogland
I moved this to draft. no need for 4.18.0.0

[DaanHoogland]

@blueorangutan test centos7 xcpng82

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + xcpng82) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-6082)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46071 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5938-t6082-vmware-67u3.zip
Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[blueorangutan]

Trillian test result (tid-6088)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7
Total time taken: 67465 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5938-t6088-xcpng82.zip
Smoke tests completed. 103 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_list_volumes_metrics_history	Failure	181.14	test_metrics_api.py
test_01_non_strict_host_anti_affinity	Error	198.60	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	Error	115.05	test_nonstrict_affinity_group.py
test_deploy_vm_with_registered_userdata	Error	783.14	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow	Error	792.49	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append	Error	788.46	test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params	Error	815.93	test_register_userdata.py
test_08_upgrade_kubernetes_ha_cluster	Error	4127.66	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.05	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	98.91	test_kubernetes_clusters.py

[yadvr]

@weizhouapache is this still relevant, or the issue has been addressed (or doesn't need to be addressed)?

[yadvr]

@weizhouapache ping, any advise on this? Is this still necessary? Thanks.

[weizhouapache]

moved to 4.18.2.0

[DaanHoogland]

is there a way forward with this @weizhouapache ?

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[weizhouapache]

closing this pr
will revisit in the future if needed