Skip to content

[UI] Added account field to upload volume#5914

Merged
nvazquez merged 3 commits into
apache:mainfrom
scclouds:Add-account-field-to-upload-volume
Feb 11, 2022
Merged

[UI] Added account field to upload volume#5914
nvazquez merged 3 commits into
apache:mainfrom
scclouds:Add-account-field-to-upload-volume

Conversation

@JoaoJandre

Copy link
Copy Markdown
Contributor

Description

This PR adds two fields (account and domain) to 'upload volume from local' and 'upload volume from URL' forms. Since the API already supports this feature, only UI changes were made.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image
image

How Has This Been Tested?

This was tested in a local lab by uploading multiple volumes to different accounts at different domains, using both forms, and checking if they were correctly assigned.

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5914 (SL-JID-1081)

@DaanHoogland

Copy link
Copy Markdown
Contributor

dialogs show nicely but it doesn't work in the qa env. I'll start a lab env.
@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2411

Comment thread ui/src/views/storage/UploadVolume.vue
@DaanHoogland

Copy link
Copy Markdown
Contributor

tested by uploading a volume from local and url for a domain/user and both were visible for the user.
code looks almost good, it will need the license in the new file to be accepted, though.

Co-authored-by: dahn <daan.hoogland@gmail.com>
@JoaoJandre

Copy link
Copy Markdown
Contributor Author

tested by uploading a volume from local and url for a domain/user and both were visible for the user. code looks almost good, it will need the license in the new file to be accepted, though.

Sorry, I forgot. I added it now :)

@utchoang utchoang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nvazquez

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5914 (SL-JID-1115)

@nvazquez nvazquez merged commit b489b58 into apache:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants