Skip to content

simplify code using optional chaining in multiple config files#5764

Merged
yadvr merged 2 commits into
apache:mainfrom
Damans227:4_issue_4956
Dec 30, 2021
Merged

simplify code using optional chaining in multiple config files#5764
yadvr merged 2 commits into
apache:mainfrom
Damans227:4_issue_4956

Conversation

@Damans227

Copy link
Copy Markdown
Collaborator

Description

This PR is related to the issue: ui: Simplify code #4956

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@Damans227

Copy link
Copy Markdown
Collaborator Author

@davidjumani @utchoang Ptal, thx!

@Damans227 Damans227 changed the title simplify code using optonal chaining in multiple config files simplify code using optional chaining in multiple config files Dec 11, 2021
@utchoang

Copy link
Copy Markdown

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5764 (SL-JID-897)

Comment thread ui/src/config/section/infra/clusters.js Outdated
Comment thread ui/src/config/section/infra/clusters.js Outdated
Comment thread ui/src/config/section/infra/clusters.js Outdated
Comment thread ui/src/config/section/infra/clusters.js Outdated
Comment thread ui/src/config/section/infra/hosts.js Outdated
Comment thread ui/src/config/section/infra/hosts.js Outdated
Comment thread ui/src/config/section/infra/zones.js Outdated
Comment thread ui/src/config/section/infra/zones.js Outdated
Comment thread ui/src/config/section/infra/zones.js Outdated
Comment thread ui/src/config/section/infra/zones.js Outdated
@Damans227 Damans227 requested a review from utchoang December 14, 2021 22:54
@utchoang

Copy link
Copy Markdown

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5764 (SL-JID-903)

@utchoang utchoang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yadvr yadvr added this to the 4.17.0.0 milestone Dec 30, 2021
@yadvr yadvr merged commit e3b0c08 into apache:main Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants