Skip to content

UI: add component was missing#4728

Merged
yadvr merged 1 commit into
apache:4.15from
utchoang:feature/add-component-use
Feb 25, 2021
Merged

UI: add component was missing#4728
yadvr merged 1 commit into
apache:4.15from
utchoang:feature/add-component-use

Conversation

@utchoang

@utchoang utchoang commented Feb 25, 2021

Copy link
Copy Markdown

Description

Fixes #4724

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

After fix:

  • Autocomplex:
    image

  • Slider:
    image

How Has This Been Tested?

@utchoang

Copy link
Copy Markdown
Author

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4728 (JID-3843)

@yadvr yadvr added this to the 4.15.1.0 milestone Feb 25, 2021
@yadvr yadvr changed the base branch from master to 4.15 February 25, 2021 08:33
@yadvr yadvr changed the base branch from 4.15 to master February 25, 2021 08:34
@yadvr yadvr changed the base branch from master to 4.15 February 25, 2021 08:34
@yadvr

yadvr commented Feb 25, 2021

Copy link
Copy Markdown
Member

@blueorangutan ui

@yadvr yadvr requested a review from shwstppr February 25, 2021 08:34
@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

@yadvr

yadvr commented Feb 25, 2021

Copy link
Copy Markdown
Member

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4728 (SL-JID-15)

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4728 (SL-JID-16)

@DaanHoogland

Copy link
Copy Markdown
Contributor

@utchoang the combobox looks fine but I am missing the slider from the vm create dialog in that ^^ buils. Am I looking in the wrong place?

@davidjumani

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4728 (SL-JID-17)

@utchoang

Copy link
Copy Markdown
Author

@DaanHoogland During my testing I found the slider component was missing so I added it.

@yadvr yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM manually verified

@yadvr yadvr merged commit 1545bf8 into apache:4.15 Feb 25, 2021
@DaanHoogland

Copy link
Copy Markdown
Contributor

@DaanHoogland During my testing I found the slider component was missing so I added it.

@utchoang , I didn't find the new slider yet, I expected it at the cpus in the instance creation wizard. Where should I look?

@utchoang

utchoang commented Mar 1, 2021

Copy link
Copy Markdown
Author

@DaanHoogland You can go to Instance -> Add instance
image

@DaanHoogland

Copy link
Copy Markdown
Contributor

ah, does it only work with the 'constrained' offering? (i tried 'unconstrained')

@utchoang utchoang deleted the feature/add-component-use branch March 8, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to add permission to a role in modern UI

6 participants