Display lb rule name instead of uuid#4524
Merged
Merged
Conversation
Display proper error message while deleting ssl cert which is associated with a load balancer rule
davidjumani
reviewed
Dec 9, 2020
| } else { | ||
| response.setAccountName(account.getAccountName()); | ||
| } | ||
| response.setAccountName(account.getAccountName()); |
Contributor
There was a problem hiding this comment.
Would be more efficient to just remove the else block below entirely
Member
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2499 |
weizhouapache
approved these changes
Jan 25, 2021
Member
|
Travis tests LGTM, merging based on code reviews and Travis tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Display proper error message while deleting ssl cert which is
associated with a load balancer rule
Also display account name to which lb belongs to
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before fix
After fix