Removed sensitive info from UI when volume attach/detach fails#4476
Merged
Conversation
Contributor
Author
|
@blueorangutan package |
|
@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Spaceman1984
changed the title
DaanHoogland
approved these changes
Nov 18, 2020
Contributor
|
@andrijapanicsb please review |
|
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2395 |
yadvr
approved these changes
Nov 18, 2020
Contributor
|
@DaanHoogland, without having time to test, I trust your Java skills 👍 |
Contributor
|
only tesxtual change in output. travis failure seems a maven central/travis issue. We get a lot of those lately. I sugest we merge this. |
Member
|
Travis lgtm, let's merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR sends the error message when attaching/detaching a volume fails only to logs and not the UI
Fixes: #4419
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
This was tested by creating a volume, attaching it to a running instance, and detaching the volume.