Packaging: new timestamp format and add output dir option#4471
Conversation
DaanHoogland
left a comment
There was a problem hiding this comment.
looks good. pudding needed
davidjumani
left a comment
There was a problem hiding this comment.
LGTM. Packages created with the new timestamp and moved to the output directory
However it would be nice to echo that the packages can be found in $OUTPUT_DIR since in the logs it mentions that the packages are being built in the current directory
dpkg-deb: building package 'cloudstack-common' in '../cloudstack-common_4.15.0.0-SNAPSHOT~eoan~eoan~eoan_all.deb'.
dpkg-deb: building package 'cloudstack-docs' in '../cloudstack-docs_4.15.0.0-SNAPSHOT~eoan~eoan~eoan_all.deb'.
dpkg-deb: building package 'cloudstack-integration-tests' in '../cloudstack-integration-tests_4.15.0.0-SNAPSHOT~eoan~eoan~eoan_all.deb'.
dpkg-deb: building package 'cloudstack-marvin' in '../cloudstack-marvin_4.15.0.0-SNAPSHOT~eoan~eoan~eoan_all.deb'.
dpkg-deb: building package 'cloudstack-usage' in '../cloudstack-usage_4.15.0.0-SNAPSHOT~eoan~eoan~eoan_all.deb'.
dpkg-deb: building package 'cloudstack-agent' in '../cloudstack-agent_4.15.0.0-SNAPSHOT~eoan~eoan~eoan_all.deb'.
dpkg-deb: building package 'cloudstack-management' in '../cloudstack-management_4.15.0.0-SNAPSHOT~eoan~eoan~eoan_all.deb'.
@davidjumani good. I will add the message |
c4b9793 to
1c5026f
Compare
|
@PaulAngus @rhtyd in spite of not being a bug fix, i think we can take this in before release, do you? |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos7 ✔centos8 ✔debian. JID-2683 |
|
Last packaging failed on centos7 due to backend issue re-running |
|
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos7 ✔centos8 ✔debian. JID-2722 |
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos7 ✔centos8 ✔debian. JID-2734 |
Description
This PR add an option "-o" to specify the output directory of packages.
Usage:
cd packaging && ./build-deb.sh -T -o ~/packages/$BRANCH_NAME
This PR also changes the format of timestamp when create packages using "./build-deb.sh -T"
old output
new output
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?