Skip to content

FIX s2svpn connection stuck on Pending state#4429

Merged
yadvr merged 1 commit into
apache:4.14from
ravening:reset-s2svpn
Oct 29, 2020
Merged

FIX s2svpn connection stuck on Pending state#4429
yadvr merged 1 commit into
apache:4.14from
ravening:reset-s2svpn

Conversation

@ravening

Copy link
Copy Markdown
Member

Description

When we try to reset the site 2 site vpn connection while
the VR's are being restarted, the connection enters the
PENDING state and we cant reset the connection.

So change the state from PENDING to disconnected.

Steps to reproduce the issue

1.create a VPC with a tier (vpc-001-001 in vpc-001), create a vm
2.create a VPC with a tier (vpc-002-001 in vpc-002) with different cidr, create a vm
3.create custom gateway for both vpn
4.enable site-to-site vpn on both vpn, and add vpn connection to each other. both should be "Connected"
5.restart vpc-001 with cleanup and monitor it
6.when the first router is destroyed, go to site-to-site vpn page and reset vpn connection.
7.we will get an error "Resource [DataCenter:1] is unreachable: Unable to apply site 2 site VPN configuration, virtual router is not in the right state"
and vpn connection is stuck at Pending
8.When vpc is restarted, go to site-to-site vpn page and reset vpn connection.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

When we try to reset the site 2 site vpn connection while
the VR's are being restarted, the connection enters the
PENDING state and we cant reset the connection.

So change the state from PENDING to disconnected.

Steps to reproduce the issue

1.create a VPC with a tier (vpc-001-001 in vpc-001), create a vm
2.create a VPC with a tier (vpc-002-001 in vpc-002) with different cidr, create a vm
3.create custom gateway for both vpn
4.enable site-to-site vpn on both vpn, and add vpn connection to each other. both should be "Connected"
5.restart vpc-001 with cleanup and monitor it
6.when the first router is destroyed, go to site-to-site vpn page and reset vpn connection.
7.we will get an error "Resource [DataCenter:1] is unreachable: Unable to apply site 2 site VPN configuration, virtual router is not in the right state"
and vpn connection is stuck at Pending
8.When vpc is restarted, go to site-to-site vpn page and reset vpn connection.

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland

Copy link
Copy Markdown
Contributor

@ravening are you intending this to make it in before 4.15?

@DaanHoogland

Copy link
Copy Markdown
Contributor

cc @PaulAngus @rhtyd

@ravening

Copy link
Copy Markdown
Member Author

@ravening are you intending this to make it in before 4.15?

@DaanHoogland the base branch is 4.14. so it should make it to 4.15 right?

@DaanHoogland

Copy link
Copy Markdown
Contributor

@ravening are you intending this to make it in before 4.15?

@DaanHoogland the base branch is 4.14. so it should make it to 4.15 right?

only if it gets merged in time

@yadvr

yadvr commented Oct 28, 2020

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2297

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@DaanHoogland DaanHoogland added this to the 4.14.1.0 milestone Oct 28, 2020
@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-3098)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30819 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4429-t3098-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@DaanHoogland

Copy link
Copy Markdown
Contributor

@rhtyd, is this bug fix ok, to you?

@yadvr yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the issue is in case of intermittent issues; this will cycle and always cause vpn to restart; so it could annoy s2s/connected parties

@yadvr yadvr merged commit 4cd9886 into apache:4.14 Oct 29, 2020
Pearl1594 pushed a commit to shapeblue/cloudstack that referenced this pull request Nov 4, 2020
When we try to reset the site 2 site vpn connection while
the VR's are being restarted, the connection enters the
PENDING state and we cant reset the connection.

So change the state from PENDING to disconnected.

Steps to reproduce the issue

1.create a VPC with a tier (vpc-001-001 in vpc-001), create a vm
2.create a VPC with a tier (vpc-002-001 in vpc-002) with different cidr, create a vm
3.create custom gateway for both vpn
4.enable site-to-site vpn on both vpn, and add vpn connection to each other. both should be "Connected"
5.restart vpc-001 with cleanup and monitor it
6.when the first router is destroyed, go to site-to-site vpn page and reset vpn connection.
7.we will get an error "Resource [DataCenter:1] is unreachable: Unable to apply site 2 site VPN configuration, virtual router is not in the right state"
and vpn connection is stuck at Pending
8.When vpc is restarted, go to site-to-site vpn page and reset vpn connection.

Co-authored-by: Rakesh Venkatesh <r.venkatesh@global.leaseweb.com>
Pearl1594 pushed a commit to shapeblue/cloudstack that referenced this pull request Nov 4, 2020
When we try to reset the site 2 site vpn connection while
the VR's are being restarted, the connection enters the
PENDING state and we cant reset the connection.

So change the state from PENDING to disconnected.

Steps to reproduce the issue

1.create a VPC with a tier (vpc-001-001 in vpc-001), create a vm
2.create a VPC with a tier (vpc-002-001 in vpc-002) with different cidr, create a vm
3.create custom gateway for both vpn
4.enable site-to-site vpn on both vpn, and add vpn connection to each other. both should be "Connected"
5.restart vpc-001 with cleanup and monitor it
6.when the first router is destroyed, go to site-to-site vpn page and reset vpn connection.
7.we will get an error "Resource [DataCenter:1] is unreachable: Unable to apply site 2 site VPN configuration, virtual router is not in the right state"
and vpn connection is stuck at Pending
8.When vpc is restarted, go to site-to-site vpn page and reset vpn connection.

Co-authored-by: Rakesh Venkatesh <r.venkatesh@global.leaseweb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants